From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: [PATCH net-next] r8169: remove unneeded call to netif_stop_queue in rtl8169_net_suspend Date: Fri, 12 Oct 2018 23:30:52 +0200 Message-ID: <0c2ef75a-3f4f-c81b-d5fc-cc1e523d61c7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: David Miller , Realtek linux nic maintainers Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:41813 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725755AbeJMFFX (ORCPT ); Sat, 13 Oct 2018 01:05:23 -0400 Received: by mail-wr1-f68.google.com with SMTP id x12-v6so14808721wru.8 for ; Fri, 12 Oct 2018 14:30:58 -0700 (PDT) Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: netif_device_detach() stops all tx queues already, so we don't need this call. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index e6e1790f4..a78be5937 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6825,7 +6825,6 @@ static void rtl8169_net_suspend(struct net_device *dev) phy_stop(dev->phydev); netif_device_detach(dev); - netif_stop_queue(dev); rtl_lock_work(tp); napi_disable(&tp->napi); -- 2.19.1