From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930932DECD8 for ; Tue, 12 Aug 2025 08:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754986627; cv=none; b=bECAgw9FPnsck5GrCszeHoW0uas7rBX1aTNqmVmCWTnqfvhi7d4YwJMl9BIQ9CeCvgihIus1YKb+YoYzBqtONzcGWIreaLJvZE7RPzmHFkhg5lPjSl22QCyd9GVy1sVCNZHy0s1OLCnimHOQQ5ADPyD6NFhwNtLUAuntb3/Sw8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754986627; c=relaxed/simple; bh=yRFc2sOlfC1VRaec8lpMMCRXQPh/gQn/3HBQl/s0F4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ry1pRIxfXh6nlRp7LiEY5bBiKkjCXggmbHMc/XQTXMm/O1ecdlqZm8P5DofR/ZbwpwBdtxmQ1OWquzWCGfl+bDT4nFVr1DheUOwW1wigIloXR7uQmXkuvKXDvTy04y2Bod+5stAh9NDwioNtgpTNzqCJ3E8M5cCPlfzU2mDh0HI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MdsP88Kl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MdsP88Kl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754986624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B+sWFNTm6ZCYaG4jfBrFltTWcj45ITlaTFvMx8eQ5+0=; b=MdsP88KlmO3ypqbclnsJb4YTp6W2Q0enq2LTqMGHPm7nsJ59//s+4+3ooi9K2VF/BO8HrL Qb7sLRLazmodue5HDt90vSfblPO0gmS4cMJLminvnZppylBMerOokwKhTSNwIAGkaYNzrR F6F4zUuerEWF1qptzyhbFndT9jcDlY8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-GqAbRIQAM2y6n4DSS_wnFw-1; Tue, 12 Aug 2025 04:17:03 -0400 X-MC-Unique: GqAbRIQAM2y6n4DSS_wnFw-1 X-Mimecast-MFC-AGG-ID: GqAbRIQAM2y6n4DSS_wnFw_1754986623 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-7073cc86450so90987106d6.2 for ; Tue, 12 Aug 2025 01:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754986622; x=1755591422; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B+sWFNTm6ZCYaG4jfBrFltTWcj45ITlaTFvMx8eQ5+0=; b=E+SihLf4dIjcZoNFH+77Sl5b+SbzmMbBmekvk2UxhQl9IsXnnvX0kIy2/egmHCGhPM 5rhj1ACmTgYORdRSSYfX6Z2ZAqHEIHQjD1k1oOLX5iJb4JLU1vefJj3VQZ9/SSMeH880 mq2kT/eWf5e2KCggH5lQfXyiEUEzvH1EeanwVeSvI6UpjARf2DtvlZBD+Ko9P1FNtSAt JC+ySeets8vyfgOJ/ZhFo7+FaEl8fq7i38LfCLKHHPyX6eKxlLGZ61BegCnu0GmvcVlz WncVZjvM/uAT3PDsQxTjjkxXD+4OXeeN3yyqCnW4urEKqHFLUFOs/+RWa/e9m+V5nXH5 fzqg== X-Gm-Message-State: AOJu0Yya2rDYHa3RcNpQLoGkhKK/3QnROCSgtRaaARTvYVRVgq2enz31 ds1cxG4hSctSuvLgB83DSPnCBKM+P/FknumPN495J8zTwAflh/dkZYJE2P7697wgzIthNWVN0C4 I8sI4svum5YWfj0TSNft8H8OgerFwz3TWbFu22GAGVGzMY3bWdnCHludrkB15B5pLpg== X-Gm-Gg: ASbGncsVgQRjNPN9rTD0L3AtkcA592dgVgo3cIBH0EYW2QgpCGbo55VLYbTYdspNy9Z ismAilo8OGIbdJ2zbT/Sd9iVvU7EBJw4wpwJEuSyWgZUQcQE7tBHpSxUYXl8OpKur8HdrAfZgMe 0weaQbDYNatdOpwwc0GetLbUnpnSG46T/lzVcd+vg8ipY40E9+Bje2H5fAo58hYh8gGzl5W2qpm 2lRf/W9Gl/VQZJ3t2OVpoYsdNpmNJ52UaU+XxcgMrvrtjo9WVmNAXqryMocrsv5is4rFUNVUjvl WUqq65UHNNyM781yw4pLomIRvNroe3PbiLhjkOFDN3Y= X-Received: by 2002:a05:6214:c84:b0:707:ba4:a21e with SMTP id 6a1803df08f44-7099a1d06cemr216500786d6.1.1754986622688; Tue, 12 Aug 2025 01:17:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJbyxt0za6gU5BC/SKoFHX+kaz9ByoX6QEm/XkTEr0Kp7Xbz+qdisalcp7XQIwZgZx/aDtsg== X-Received: by 2002:a05:6214:c84:b0:707:ba4:a21e with SMTP id 6a1803df08f44-7099a1d06cemr216500656d6.1.1754986622302; Tue, 12 Aug 2025 01:17:02 -0700 (PDT) Received: from [192.168.0.115] ([212.105.149.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70937821c2esm147748396d6.68.2025.08.12.01.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Aug 2025 01:17:01 -0700 (PDT) Message-ID: <0c3291b0-ab8a-4958-b317-ffdafe61b332@redhat.com> Date: Tue, 12 Aug 2025 10:16:59 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] ipv6: Check AF_UNSPEC in ip6_route_multipath_add() To: Maksimilijan Marosevic , davem@davemloft.net, dsahern@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, syzbot+a259a17220263c2d73fc@syzkaller.appspotmail.com References: <20250804204233.1332529-1-maksimilijan.marosevic@proton.me> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250804204233.1332529-1-maksimilijan.marosevic@proton.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/4/25 10:42 PM, Maksimilijan Marosevic wrote: > This check was removed in commit e6f497955fb6 ("ipv6: Check GATEWAY > in rtm_to_fib6_multipath_config().") as part of rt6_qualify_for ecmp(). > The author correctly recognises that rt6_qualify_for_ecmp() returns > false if fb_nh_gw_family is set to AF_UNSPEC, but then mistakes > AF_UNSPEC for AF_INET6 when reasoning that the check is unnecessary. > This means certain malformed entries don't get caught in > ip6_route_multipath_add(). > > This patch reintroduces the AF_UNSPEC check while respecting changes > of the initial patch. > > Reported-by: syzbot+a259a17220263c2d73fc@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=a259a17220263c2d73fc > Fixes: e6f497955fb6 ("ipv6: Check GATEWAY in rtm_to_fib6_multipath_config().") > Signed-off-by: Maksimilijan Marosevic Please resend in a 2 patches series including an additional self-test as asked by David. Also please insert into the subj prefix the target tree ('net' in this case) and add Kuniyuki into the CC list. Thanks, Paolo