From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD6124E4D4 for ; Thu, 28 Aug 2025 15:08:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756393732; cv=none; b=ANhAPf8iQvYOGAaY/Ni+NAEbC/oWL2g7cqSPiYTIXeYHbZJbVRmJS6P4gBMR/4Ljr7uQpTOtoNLSNVUDC7XYw5VukSkf3THxFCDgYbK8jH/x5F9zifKcWtR2yremWIyJcN0mejAhLHBIHNDUNiYRsgKPavrIgc9sN8N5ZpQxTN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756393732; c=relaxed/simple; bh=icOFXtpyTr+v62nWJkhrG9QgJ0lD5a5gT8SO+Skige0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=agL6An/DcTCAln1PLd7J5HmbZK7FEDEIzs9jEy1EqM5CC+ftwRFrqJK+VF6/ceh8V1+Q6u8RLywI6O0/0OtIkmzRWIN8WDyE8SrVpXqx4wrCZX/h377nU4TfKOu6P6INHOX0xKKP32L1gR1JnPtWS7jo/Mwzgb/mKNmkTegx5lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jAJh2ab9; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jAJh2ab9" Message-ID: <0c5a5a2d-59f6-4a31-9c09-7df8f9117a31@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756393727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+I3SDsSbN1coFtYj99WmS0+2o5TVYr/BtAhlhZ/HgE=; b=jAJh2ab95ttb0ewNQ7bbtJPVHIl6fvKKfYzEJgfu1RIsYfdVjNlT0LAkZJK9EN/Jd5rhIC Hu+gSU3G7bjeXP9t/36VyBy8e/64MYv0nePmOuWp+JQ19NzBgaxaAMOzvovZguALS50MBG xqa5Zy88eVhwu009ucC3Ey3wEhWgC9U= Date: Thu, 28 Aug 2025 16:08:42 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v02 13/14] hinic3: Fix missing napi->dev in netif_queue_set_napi To: Fan Gong , Zhu Yikai Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , linux-doc@vger.kernel.org, Jonathan Corbet , Bjorn Helgaas , luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Meny Yossefi , Gur Stavi , Lee Trager , Michael Ellerman , Suman Ghosh , Przemek Kitszel , Christophe JAILLET References: <71685e8f14c4523add7580dbfd078b1b2763f7c3.1756378721.git.zhuyikai1@h-partners.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <71685e8f14c4523add7580dbfd078b1b2763f7c3.1756378721.git.zhuyikai1@h-partners.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 28/08/2025 13:10, Fan Gong wrote: > As netif_queue_set_napi checks napi->dev, if it doesn't have it and > it will warn_on and return. So we should use netif_napi_add before > netif_queue_set_napi because netif_napi_add has "napi->dev = dev". > > Co-developed-by: Xin Guo > Signed-off-by: Xin Guo > Co-developed-by: Zhu Yikai > Signed-off-by: Zhu Yikai > Signed-off-by: Fan Gong > --- > drivers/net/ethernet/huawei/hinic3/hinic3_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c > index 33eb9080739d..a69b361225e9 100644 > --- a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c > +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c > @@ -42,11 +42,11 @@ static void qp_add_napi(struct hinic3_irq_cfg *irq_cfg) > { > struct hinic3_nic_dev *nic_dev = netdev_priv(irq_cfg->netdev); > > + netif_napi_add(nic_dev->netdev, &irq_cfg->napi, hinic3_poll); > netif_queue_set_napi(irq_cfg->netdev, irq_cfg->irq_id, > NETDEV_QUEUE_TYPE_RX, &irq_cfg->napi); > netif_queue_set_napi(irq_cfg->netdev, irq_cfg->irq_id, > NETDEV_QUEUE_TYPE_TX, &irq_cfg->napi); > - netif_napi_add(nic_dev->netdev, &irq_cfg->napi, hinic3_poll); > napi_enable(&irq_cfg->napi); > } > Reviewed-by: Vadim Fedorenko