From: David Ahern <dsahern@kernel.org>
To: Ralf Lici <ralf@mandelbit.com>
Cc: netdev@vger.kernel.org, Antonio Quartulli <antonio@openvpn.net>,
Sabrina Dubroca <sd@queasysnail.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net 1/1] ovpn: avoid caching stale IPv6 dst after FIB changes
Date: Tue, 29 Sep 2026 08:09:46 -0600 [thread overview]
Message-ID: <0c6f073c-12c7-4843-846e-69c48c290107@kernel.org> (raw)
In-Reply-To: <20260928085639.151005-1-ralf@mandelbit.com>
On 9/28/26 3:56 AM, Ralf Lici wrote:
> Hi David,
>
> Just following up on this. Does my previous example clarify why storing
> an old dst with a new cookie defeats reuse-time validation?
>
> If so, would you prefer that I pursue the kernel-wide lookup-provenance
> approach described in the RFC, or keep the fix self-contained in ovpn?
> The same late-cookie-sampling pattern is used by several drivers and
> callers in the networking core, so I think fixing it generically is the
> better architectural choice.
>
> If changing the generic interfaces is not acceptable, I can rework the
> patch as an ovpn-local fix, although that would duplicate IPv6 routing
> details in the driver and leave the equivalent pattern elsewhere
> unchanged.
>
dst's are cached in lots of places. Why does ovpn need internal routing
details that the other places do not?
next prev parent reply other threads:[~2026-09-29 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:09 [PATCH net 0/1] ovpn: avoid caching stale IPv6 dst after FIB changes Ralf Lici
2026-09-17 10:09 ` [PATCH net 1/1] " Ralf Lici
2026-09-17 19:09 ` David Ahern
2026-09-18 6:51 ` Ralf Lici
2026-09-18 18:42 ` David Ahern
2026-09-18 20:27 ` Ralf Lici
2026-09-28 8:56 ` Ralf Lici
2026-09-29 14:09 ` David Ahern [this message]
2026-09-29 15:04 ` Ralf Lici
2026-10-09 0:33 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c6f073c-12c7-4843-846e-69c48c290107@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox