From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Kalle Valo <kvalo@kernel.org>,
Vinayak Yadawad <vinayak.yadawad@broadcom.com>
Cc: linux-wireless@vger.kernel.org, jithu.jance@broadcom.com,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 1/1] wifi: nl80211: Add support for plumbing SAE groups to driver
Date: Tue, 13 Feb 2024 12:45:30 +0100 [thread overview]
Message-ID: <0cb1d7ef63ad1ea1ff4109d85a6bcdcaca16f1c8.camel@sipsolutions.net> (raw)
In-Reply-To: <df8f02b1-25b0-4dae-a935-cee9ba7f3dc4@broadcom.com>
On Tue, 2024-02-13 at 12:13 +0100, Arend van Spriel wrote:
>
> I recall the rule was that nl80211 API changes
> should also have at least one driver implementing it. Guess we let that
> slip a couple of times. I fully agree enforcing this.
Well, enforcing it strictly never really worked all that well in
practice, since you don't necessarily want to have a complex driver
implementation while hashing out the API, and the API fundamentally has
to come first.
So in a sense it comes down to trust, and that people will actually
follow up with implementations. And yeah, plans can change and you end
up not really supporting everything that was defined ... that's life, I
guess.
But the mode here seems to be that there's not even any _intent_ to do
that?
I guess we could hash out the API, review the patches, and then _not_
apply them until a driver is ready? So the first round of reviews would
still come with API only, but once that settles we don't actually merge
it immediately, unlike normally where we merge a patch we've reviewed?
And then if whoever did it lost interest, we already have a reviewed
version for anyone else who might need it?
> FWIW I am actually
> planning on submitting brcmfmac patches to support
> NL80211_CMD_EXTERNAL_AUTH.
Cool :)
johannes
next prev parent reply other threads:[~2024-02-13 11:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <309965e8ef4d220053ca7e6bd34393f892ea1bb8.1707486287.git.vinayak.yadawad@broadcom.com>
[not found] ` <87mss6f8jh.fsf@kernel.org>
2024-02-12 19:58 ` [PATCH 1/1] wifi: nl80211: Add support for plumbing SAE groups to driver Johannes Berg
2024-02-13 9:42 ` Arend van Spriel
2024-02-13 10:09 ` Johannes Berg
2024-02-13 11:13 ` Arend van Spriel
2024-02-13 11:45 ` Johannes Berg [this message]
2024-02-13 12:19 ` Arend van Spriel
2024-02-13 12:30 ` Johannes Berg
2024-02-13 12:50 ` Kalle Valo
2024-02-13 13:43 ` Jithu Jance
2024-02-13 12:46 ` Kalle Valo
2024-02-14 1:43 ` Jakub Kicinski
2024-02-14 10:27 ` Johannes Berg
2024-02-14 16:08 ` Jakub Kicinski
2024-02-14 16:57 ` Jeff Johnson
2024-02-27 19:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cb1d7ef63ad1ea1ff4109d85a6bcdcaca16f1c8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jithu.jance@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vinayak.yadawad@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).