From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC98EC433B4 for ; Fri, 23 Apr 2021 12:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B20A61461 for ; Fri, 23 Apr 2021 12:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235549AbhDWMcj (ORCPT ); Fri, 23 Apr 2021 08:32:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhDWMci (ORCPT ); Fri, 23 Apr 2021 08:32:38 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 210F7C061574 for ; Fri, 23 Apr 2021 05:32:02 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id e186so276564iof.7 for ; Fri, 23 Apr 2021 05:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=HKActNop4gfNe3Hlyu9iK5cONXIFZVN6yVZQhfm5rPQ=; b=ECve+nuTRjnE8hpecoqXVT13cPTOKj/FXQ9pOX79XUhj2sscUJtt2GHZD0DHbHMxJZ bVWjOrPy3PHryAtGSTzpEQ0HTSEHtKEPcaxBY8y8PyTi6x1OIZVWx2Ws/k+y82Ngxhg2 YiS1cFOXUlDzSJAlS+L1XVsKXNeCvi7s+D12rsTqgwSMRyPi/CiNESh5Ox+xCqKBUkQu I1CdO6H9Hmu/cxbqZcjgoaZD66Tha8Qkx/826mx62TQLqYYsh+qiqGxGzlASSv0ATQnx dIgyhwWESaaFL5XZ0pM0VxKMc9D7TwcG8VfIcKCbCzD8d2/oOxs6xYL+IoH0cCnSKN/b ihlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HKActNop4gfNe3Hlyu9iK5cONXIFZVN6yVZQhfm5rPQ=; b=FQ67+xhdCHgoUo+CX+anFEZkA5Jy0WxtaeFzPOTqTNCIHDwrxDFVvh7p3InaIXtFjt Y8oRAIm1OdiEwr9tAgZdjdSp63puGJwHEQ/Hrd6LUoSpd+QU1bU1uG5EUlhkegNU4iF4 8wi/SKuWpq7ecNQsJZ4yL+MmsLj/XSeTmxPaWMli4GJNMWkYe/2yUEQbW5d3zYB+ggPz inGA022UiWMwglxv3E88Ptq0BU74Ms3GXJU1NlyGPXS+Jb8qmBKcbsrSh0ZBm9st0nlh 8hCbVOhuosJVtFrBBruSIL5OkhCbx2sz63gOfeeVvI3eAaYPL5tGqTAHvuJWzR1A5Rz+ ol7g== X-Gm-Message-State: AOAM530QHYfzlnk/UtYmV/5/Ok25uSgKlVn1bvs/N9U9/C/NAnoB3i/7 uxniKzWe497VHxqmRV8Gr28MXZao0dP/Dg== X-Google-Smtp-Source: ABdhPJywguvpb/+jI3NnQ7APn2skk4sAEhoqPEZGt45r/b0cDl7LRNFSWZV1Su8m2+ZtjAnTAYc6qw== X-Received: by 2002:a6b:f602:: with SMTP id n2mr3169787ioh.174.1619181120360; Fri, 23 Apr 2021 05:32:00 -0700 (PDT) Received: from [172.22.22.4] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id b8sm2814913iob.30.2021.04.23.05.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 05:31:59 -0700 (PDT) Subject: Re: [PATCH net-next v4 0/3] net: qualcomm: rmnet: Enable Mapv5 To: Sharath Chandra Vurukala , davem@davemloft.net, kuba@kernel.org, elder@kernel.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1619121731-17782-1-git-send-email-sharathv@codeaurora.org> From: Alex Elder Message-ID: <0cbcc4aa-8457-f17a-6d73-a99699bd5a2c@linaro.org> Date: Fri, 23 Apr 2021 07:31:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1619121731-17782-1-git-send-email-sharathv@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/22/21 3:02 PM, Sharath Chandra Vurukala wrote: > This series introduces the MAPv5 packet format. > > Patch 0 documents the MAPv4/v5. > Patch 1 introduces the MAPv5 and the Inline checksum offload for RX/Ingress. > Patch 2 introduces the MAPv5 and the Inline checksum offload for TX/Egress. > > A new checksum header format is used as part of MAPv5.For RX checksum offload, > the checksum is verified by the HW and the validity is marked in the checksum > header of MAPv5. For TX, the required metadata is filled up so hardware can > compute the checksum. It turns out many of review comments from last week were ignored without explanation. So I will repeat some of them this time. I see one thing that I think might be a bug in the third patch, but maybe I'm mistaken, and you can explain why. I tested the code you supplied me last week, and with a bug fix applied I found they worked for: IPA v3.5.1, IPv4 in loopback, checksum enabled and not IPA v4.2, IPv6 using LTE, checksum enabled and not Both of the above tested ICMP, UDP, and TCP. I will retest with this series. I did not test with IPA v4.5+, which is unfortunately the main user of this new code. I will try to do so with your updated code, and if all testing passes I'll send a message with "Tested-by" for you to add to your patches. -Alex > v1->v2: > - Fixed the compilation errors, warnings reported by kernel test robot. > - Checksum header definition is expanded to support big, little endian > formats as mentioned by Jakub. > > v2->v3: > - Fixed compilation errors reported by kernel bot for big endian flavor. > > v3->v4: > - Made changes to use masks instead of C bit-fields as suggested by Jakub/Alex. > > Sharath Chandra Vurukala (3): > docs: networking: Add documentation for MAPv5 > net: ethernet: rmnet: Support for ingress MAPv5 checksum offload > net: ethernet: rmnet: Add support for MAPv5 egress packets > > .../device_drivers/cellular/qualcomm/rmnet.rst | 126 +++++++++++++++-- > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 4 +- > .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 29 ++-- > drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 11 +- > .../net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 151 ++++++++++++++++++++- > drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 +- > include/linux/if_rmnet.h | 27 +++- > include/uapi/linux/if_link.h | 2 + > 8 files changed, 318 insertions(+), 35 deletions(-) >