From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs Date: Wed, 15 Aug 2018 10:43:25 -0600 Message-ID: <0ce24184-cf62-5623-5a7c-b1b32ab8b1c3@gmail.com> References: <20180815162127.21477-1-phil@nwl.cc> <20180815162127.21477-5-phil@nwl.cc> <06633975-40ae-f3d6-b5a9-8a947752e400@gmail.com> <20180815163944.GT32448@orbyte.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Phil Sutter , Stephen Hemminger , netdev@vger.kernel.org, Till Maas Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:41212 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729878AbeHOTgV (ORCPT ); Wed, 15 Aug 2018 15:36:21 -0400 Received: by mail-pl0-f66.google.com with SMTP id w19-v6so687290ply.8 for ; Wed, 15 Aug 2018 09:43:27 -0700 (PDT) In-Reply-To: <20180815163944.GT32448@orbyte.nwl.cc> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 8/15/18 10:39 AM, Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: >> On 8/15/18 10:21 AM, Phil Sutter wrote: >>> Add an additional prerequisite to check_enable_color() to make sure >>> stdout actually points to an open TTY device. Otherwise calls like >>> >>> | ip -color a s >/tmp/foo >>> >>> will print color escape sequences into that file. Allow to override this >>> check by specifying '-color' flag more than once. >>> >>> Signed-off-by: Phil Sutter >>> --- >>> Changes since v1: >>> - Allow to override isatty() check by specifying '-color' flag more than >>> once. >> >> That adds overhead to my workflow where I almost always have to pipe the >> output of ip to a pager. > > alias ip='ip -color -color' no. Don't impact existing users. > > Another alternative may be to introduce -autocolor flag. Establishing > the same syntax as used by 'ls' is not as trivial due to the simple > commandline parsing used in 'ip'. I disagree with ignoring or overriding an argument a user passes in. You are guessing what is the correct output and you are guessing wrong. There is nothing wrong with piping output to a file and the viewing that file through 'less -R'. If a user does not want the color codes in the file, then that user can drop the -color arg. iproute2 commands should not be guessing.