From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource
 controller via devlink
Date: Thu, 29 Mar 2018 14:01:06 -0600
Message-ID: <0d0f6ef6-111b-1cb9-1cd6-2ccdef5d5020@cumulusnetworks.com>
References: <20180328012200.15175-1-dsa@cumulusnetworks.com>
 <20180328012200.15175-7-dsa@cumulusnetworks.com>
 <20180327183450.34d6e9b6@cakuba.netronome.com>
 <20180329.141119.1343151558612891683.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
        shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com,
        andy.roulin@gmail.com
To: David Miller <davem@davemloft.net>, jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f42.google.com ([74.125.83.42]:34619 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751082AbeC2UBJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Mar 2018 16:01:09 -0400
Received: by mail-pg0-f42.google.com with SMTP id y16so3200621pgv.1
        for <netdev@vger.kernel.org>; Thu, 29 Mar 2018 13:01:09 -0700 (PDT)
In-Reply-To: <20180329.141119.1343151558612891683.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/29/18 12:11 PM, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Tue, 27 Mar 2018 18:34:50 -0700
> 
>> On Tue, 27 Mar 2018 18:22:00 -0700, David Ahern wrote:
>>> +void nsim_devlink_setup(struct netdevsim *ns)
>>> +{
>  ...
>> nit: DaveM expressed preference to not have silent failures in a
>>      discussion about DebugFS, not sure it applies here, but why not
>>      handle errors?
> 
> Yes it is a concern.
> 
> David please address this as a follow-up.

Will do.