From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FC1C43381 for ; Fri, 29 Mar 2019 21:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D4BF218A2 for ; Fri, 29 Mar 2019 21:29:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MbdpCj7P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730112AbfC2V3Q (ORCPT ); Fri, 29 Mar 2019 17:29:16 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:41253 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729998AbfC2V3P (ORCPT ); Fri, 29 Mar 2019 17:29:15 -0400 Received: by mail-pf1-f196.google.com with SMTP id 188so1630165pfd.8 for ; Fri, 29 Mar 2019 14:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Zik8Ce2TLg4WsZBJE0eEpXT3J6FsyQKcV1V+qAkJE4Q=; b=MbdpCj7P91PqyQEHty5uDnXMMDBrQsGpbqC7qhG9sp6xcCwK8RY5lwoVDe3ZSf0vp9 xycRtfBrA8J3cH5O7q0MhmiuRquhnB7ijhm0keYCKqwVRPcGpMs/bUXQ/RHhcRWGoWdp Q6ibL1HGYAMmz8MXQc70CQjWOhH/oSx8Zoqor9mq8qyKhEgJkelxQjuKE011sal5/PGz 28aWNCb3Ze3t9yjRqdy0GYQumuQQg5K5lYeGQBbzBYWw1MT/qO/HtnDUDe0yUPxoo/ir qcs3sICuGvwypbx9fBvEg+b4J8PmVBqZTIlzYHKVnQeljkG6mHIURDhERBLA/BQI5oUC p73w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Zik8Ce2TLg4WsZBJE0eEpXT3J6FsyQKcV1V+qAkJE4Q=; b=YBM2U6G+0Vpq0A145KP+IRnoIhHPMCASdp7dsESNKYbRUy3olkurBV1o0pSySZVdj0 yajWI+Y6ZBWt9qj9NybH2Bnh7zb9TMu3ClUwzV7BkOMoULzObO8hyBYvJfUFi/X2aE/t Qq+UxMIAO6ISiLaVO7PU84rnt0AWvoyTJC+iZSN1+erKGO9t+z6Mgi6BoLR3tnhh8+QX 2hTNAMR6kirn8BaDLo/n/KivROT+dK37hM2x+yogVMIpPX2hCyO9ulxRv/5rEbjksRHB qaVPjfX/CBA7O6T89mofXbsoZTwXkYzdTYIqP6lKS6bhGuvkTiIRWbABdea44wS6at4C DLBg== X-Gm-Message-State: APjAAAXcpCUIRLu+jp+s8c2G4MZjaHJJXVXseC+vssTL7YL3KA91eXWE jd/6apUJ72vTVB2BsBr8g8Q= X-Google-Smtp-Source: APXvYqzn857V6JGpQ98HMHzgdaFaUs6EsY1OVU3L3VVBcMVxmsQMfHOd2E+j8Fva3n9dVXpft9E3zg== X-Received: by 2002:a63:5061:: with SMTP id q33mr21840416pgl.218.1553894954771; Fri, 29 Mar 2019 14:29:14 -0700 (PDT) Received: from [10.67.49.126] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id j12sm3263243pgg.79.2019.03.29.14.29.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 14:29:13 -0700 (PDT) Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink To: Jakub Kicinski , Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com References: <20190328211254.1894-1-jiri@resnulli.us> <20190328144002.245c9eef@cakuba.netronome.com> <20190329064905.GS14297@nanopsycho> <20190329115926.5c16d2fd@cakuba.netronome.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <0d1e99ef-38d4-93bd-ad79-dd9002b3f468@gmail.com> Date: Fri, 29 Mar 2019 14:29:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190329115926.5c16d2fd@cakuba.netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/29/19 11:59 AM, Jakub Kicinski wrote: > On Fri, 29 Mar 2019 07:49:05 +0100, Jiri Pirko wrote: >> Thu, Mar 28, 2019 at 10:40:02PM CET, jakub.kicinski@netronome.com wrote: >>> On Thu, 28 Mar 2019 22:12:42 +0100, Jiri Pirko wrote: >>>> From: Jiri Pirko >>>> >>>> To provide visibility of the ports, this patchset exposes switch ID >>>> for devlink ports, which are part of a switch. The rest of the ports >>>> if any (in case of sr-iov for example) do not set switch ID. >>> >>> I don't feel good about this patch set. There is no visibility >>> provided here. Should the port flavour should be a sufficient >> >> 1) this patch is mainly about avoiding need to define the ndo and moving >> the switch id definition to devlink port attr. > > Sure, that you could achieve by putting the data in the netdevice > structure as well.. > > What is the guiding principle here? I'm trying to argue for leaving > forwarding-related info in netdev code, and only have HW control in > devlink. I just don't see switch id being useful at devlink level in > any way. > >> 2) along with that, switch id is added as attribute. It tells the user >> that some devlink port is part of a switch with certain id. If port >> is not part of a switch (like upcoming hostport, cpu, dsa, etc), >> switch id is not set on that port > > If the flavour already gives that information, why crowd the attributes > for ports with switch id? > >>> indication of whether netdev associated with that port can be >>> switched to or not? CPU, DSA, and Host flavours can't be switched >>> to. And the switchid can be an attribute of the devlink instance, >>> if we want to expose it via devlink. >> >> One devlink instance can have multiple switch ids in use as it may >> contain multiple switches. Take mlx5 as an instance. Currently every PF >> creates a separate devlink instance, however there are some features >> shared. In this example, with proposed idea of aliasing, there would be >> one devlink instance aliased between these 2 pf inctances, with 2 >> eswitches and 2 sets of switch ports each belonging to an eswitch - >> distinguished by switch id. > > Out of curiosity, what are the shared features? It seems mlx5 drives > a lot of our API design, it'd be good if the community had a better > understanding of it. > > The situation with pipelined devices is somewhat murky. Didn't Or add > some from of PCIe-side looped queue to forward between PFs? > > Presumably DSA would lean the opposite way with multiple ASICs > reporting the same ID? If you have multiple switches inter connected between each other to use the "D" in DSA and form a fabric of switches, then you would expect each port to be physically tied to a particular switch device/instance, because, but how they will report the switch physical ID can be of the form: . where fabric is dst->index and switch is ds->index (the switch within the fabric). -- Florian