From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC61C4338F for ; Wed, 18 Aug 2021 20:44:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03F8B610F7 for ; Wed, 18 Aug 2021 20:44:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233865AbhHRUok (ORCPT ); Wed, 18 Aug 2021 16:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233775AbhHRUog (ORCPT ); Wed, 18 Aug 2021 16:44:36 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424C4C061764 for ; Wed, 18 Aug 2021 13:44:01 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id x10-20020a056830408a00b004f26cead745so5703192ott.10 for ; Wed, 18 Aug 2021 13:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R1kdr3yVQ3oL4ieUyASNKHJeUhPfiya7e+NKpbfOK6E=; b=bKH8bq1+iBUKE3sgdAYttOwN3XKNA0IM0pMc/7PshDgh2xLX51rDUmmIYoBNAJ25sM ZCvJhemDxJOpT1bYA9OwO4wLbO25dd5Mkwxskn3IlVIdMJ3oSED+J780GTvjJW/JDppd 5eQSayMtDeURx2VTWApoOiStIw7jyJncIMVRxH+ZK2//DOWcYYZiIe7WEUGJvwSHu6qO vk8dutCef9XTxLuHwJ+gUYS493AZk7djzLGEEqBYSF1QTa/0WCh/o3LNuyp4LNxyPWeJ Jnil9w55OAKj/zOYXmCusnVWzFukq9nHurDzu8MuJXT4X6dboqGdYX8Slx8Gnh1Edjzm db2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R1kdr3yVQ3oL4ieUyASNKHJeUhPfiya7e+NKpbfOK6E=; b=UdAoV3DvOJwGB65FAKR4I3SBCmugMx2VcnF1nVPskTNg1i12o5iyPKH4V+pKzJRuBN FVZ+YK5kORlLhNX/KnITxmFWUHvWA5EuoAKEdiEWWtoMzK+CV9eZmuQzdJ1ed5av8Kif j2tSBkPSHjD1jvnbPWRWDnG2a/DOQw8e0hPFFpGisX6ylCO04FJplX26u4yy/vol6KEU gacmqgaPUZN5Ff8D1oogn7Q0qyftWvesSpl+4JtXzbNng40DR54Pzux+237qwcK14BD1 /vvL7OUtriYGQj1G9E1Wwf112h6Rj+sYKSP6IAuSxCCZXoUQKcZ4AYbsCWIvgc9gplIq 73Ag== X-Gm-Message-State: AOAM533ZnQZjm15FK8W/FRwj4zZoZ5tGO0OR6nkmZfM6gcpEKOvVe8fB dM4tySsfsUQMipCPTwbUldSwU+SYONo= X-Google-Smtp-Source: ABdhPJwNjwVgI2Q6S5XtMHs5X1SHKdw0H/cy2SW0GnpqmFPBb3K2OiH6kI+PhfFGoYz88aFmawvXkA== X-Received: by 2002:a05:6830:47:: with SMTP id d7mr8456773otp.108.1629319440527; Wed, 18 Aug 2021 13:44:00 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.45]) by smtp.googlemail.com with ESMTPSA id d26sm169723oos.41.2021.08.18.13.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 13:44:00 -0700 (PDT) Subject: Re: ss command not showing raw sockets? (regression) To: Jonas Bechtel Cc: Jakub Kicinski , netdev@vger.kernel.org References: <20210815231738.7b42bad4@mmluhan> <20210816150800.28ef2e7c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210817080451.34286807@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210817202135.6b42031f@mmluhan> <20210817114402.78463d9d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210817143753.30f21bb0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <74deda94-f14e-be9e-6925-527c7b70a563@gmail.com> <20210818215738.1830fd0b@mmluhan> From: David Ahern Message-ID: <0d301c66-0702-d87b-a815-f526f5971036@gmail.com> Date: Wed, 18 Aug 2021 14:43:58 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210818215738.1830fd0b@mmluhan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/18/21 1:57 PM, Jonas Bechtel wrote: > > > > On Tue, 17 Aug 2021 18:47:06 -0600 > David Ahern wrote with subject > "Re: ss command not showing raw sockets? (regression)": > >> On 8/17/21 3:37 PM, Jakub Kicinski wrote: >>> >>> Ah, good point, strace will show it. >>> >>> /me goes off to look at the strace Jonas sent off list. >>> >>> Well this is unexpected: >>> >>> sendmsg(3, {msg_name={sa_family=AF_NETLINK, nl_pid=0, >>> nl_groups=00000000}, msg_namelen=12, msg_iov=[{iov_base={{len=76, >>> type=DCCPDIAG_GETSOCK, ... --->8---------------- >>> >>> From: Jakub Kicinski >>> Subject: ss: fix fallback to procfs for raw and sctp sockets >>> >>> sockdiag_send() diverts to tcpdiag_send() to try the older >>> netlink interface. tcpdiag_send() works for TCP and DCCP >>> but not other protocols. Instead of rejecting unsupported >>> protocols (and missing RAW and SCTP) match on supported ones. >>> >>> Fixes: 41fe6c34de50 ("ss: Add inet raw sockets information >>> gathering via netlink diag interface") Signed-off-by: Jakub >>> Kicinski --- >>> misc/ss.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/misc/ss.c b/misc/ss.c >>> index 894ad40574f1..b39f63fe3b17 100644 >>> --- a/misc/ss.c >>> +++ b/misc/ss.c >>> @@ -3404,13 +3404,13 @@ static int tcpdiag_send(int fd, int >>> protocol, struct filter *f) struct iovec iov[3]; >>> int iovlen = 1; >>> >>> - if (protocol == IPPROTO_UDP || protocol == IPPROTO_MPTCP) >>> - return -1; >>> - >>> if (protocol == IPPROTO_TCP) >>> req.nlh.nlmsg_type = TCPDIAG_GETSOCK; >>> - else >>> + else if (protocol == IPPROTO_DCCP) >>> req.nlh.nlmsg_type = DCCPDIAG_GETSOCK; >>> + else >>> + return -1; >>> + >>> if (show_mem) { >>> req.r.idiag_ext |= (1<<(INET_DIAG_MEMINFO-1)); >>> req.r.idiag_ext |= (1<<(INET_DIAG_SKMEMINFO-1)); >>> >> >> That looks correct to me. >> >> Jonas: can you build iproute2 and test? > > I've cloned branch main as instructed in https://wiki.linuxfoundation.org/networking/iproute2. Most recent commit is 9b7ea92b9e3f. After building, no socket was listed in table. > > Then I [manually] applied the patch and rebuilt. The patched version works well, I do see the two sockets right now. > > Command was in both cases misc/ss -awp > Awesome, thanks for doing that. Jakub: want to send a formal patch with his Tested-by?