From: Paolo Abeni <pabeni@redhat.com>
To: Hangbin Liu <hangbin.liu@linux.dev>, luyun <luyun_611@163.com>
Cc: jv@jvosburgh.net, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, maheshb@google.com,
razor@blackwall.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v3] bonding: 3ad: select a port when the TX array is empty
Date: Tue, 20 Oct 2026 09:06:15 +0200 [thread overview]
Message-ID: <0d32d785-d16a-456d-98e5-8e952d09ab76@redhat.com> (raw)
In-Reply-To: <asyt2Gt4LzKWWnZS@fedora>
On 10/12/26 11:52, Hangbin Liu wrote:
> On Mon, Oct 12, 2026 at 03:20:09PM +0800, luyun wrote:
>> On cost: the fallback only runs when the array is empty, so the normal
>> transmit path is untouched. Inside the window it is a lockless RCU list
>> walk with no new state; the second pass and the broadcast branch are
>> there to keep the array path's hash mapping and broadcast_neighbor
>> semantics.
>>
>> I would also like Jay's feedback on the preferred direction. If a
>> control-path solution is preferred, I am open to working on separating
>> array preparation from port enablement, as long as it does not change
>> LACP convergence behavior.
>
> +1
I guess we are not getting Jay's feedback anytime soon.
I think a control-plane solution is highly preferable, even if it's
going to be a more significant work. I have just skimmed over the code
and it feels like removing the rtnl lock requirement for
bond_update_slave_arr() is doable - i.e. moving ->all_slaves and
->usable_slaves under a new bond specific mutex).
Thanks,
Paolo
prev parent reply other threads:[~2026-10-20 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 2:40 [PATCH net v3] bonding: 3ad: select a port when the TX array is empty Yun Lu
2026-10-10 9:43 ` Hangbin Liu
2026-10-12 7:20 ` luyun
2026-10-12 9:52 ` Hangbin Liu
2026-10-20 7:06 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d32d785-d16a-456d-98e5-8e952d09ab76@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hangbin.liu@linux.dev \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=luyun_611@163.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox