From: Paolo Abeni <pabeni@redhat.com>
To: Bobby Eshleman <bobbyeshleman@gmail.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Shuah Khan <shuah@kernel.org>
Cc: kvm@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock
Date: Tue, 20 May 2025 13:24:43 +0200 [thread overview]
Message-ID: <0d3a3a42-4141-4c4d-b25a-3c9181d5842e@redhat.com> (raw)
In-Reply-To: <20250515-vsock-vmtest-v7-1-ba6fa86d6c2c@gmail.com>
On 5/16/25 12:00 AM, Bobby Eshleman wrote:
> +tap_prefix() {
> + sed -e "s/^/${TAP_PREFIX}/"
> +}
I think there is no need to the tap prefix to the output you intend to
'comment out', the kselftest infra should already add the tap prefix
mark to each line generated by the test,
> +
> +tap_output() {
> + if [[ ! -z "$TAP_PREFIX" ]]; then
AFAICS TAP_PREFIX is a not empty string constant, so this function is
always a no op. If so it should be dropped.
Otherwise LGTM, thanks,
Paolo
next prev parent reply other threads:[~2025-05-20 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 22:00 [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock Bobby Eshleman
2025-05-20 8:24 ` Stefano Garzarella
2025-05-20 10:58 ` Paolo Abeni
2025-05-20 11:09 ` Stefano Garzarella
2025-05-20 16:33 ` Bobby Eshleman
2025-05-20 16:31 ` Bobby Eshleman
2025-05-20 11:24 ` Paolo Abeni [this message]
2025-05-20 16:09 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3a3a42-4141-4c4d-b25a-3c9181d5842e@redhat.com \
--to=pabeni@redhat.com \
--cc=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox