From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 0/4] ipv6: Add support for non-equal-cost multipath Date: Tue, 9 Jan 2018 21:38:14 -0700 Message-ID: <0d3d86fe-01ff-27ff-57c0-33e04fb5da90@gmail.com> References: <20180109144028.30133-1-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, pch@ordbogen.com, jkbs@redhat.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:43437 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756125AbeAJEiQ (ORCPT ); Tue, 9 Jan 2018 23:38:16 -0500 Received: by mail-pg0-f65.google.com with SMTP id f14so7340166pga.10 for ; Tue, 09 Jan 2018 20:38:16 -0800 (PST) In-Reply-To: <20180109144028.30133-1-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/9/18 7:40 AM, Ido Schimmel wrote: > This set aims to add support for IPv6 non-equal-cost multipath routes. > The first three patches convert multipath selection to use the > hash-threshold method (RFC 2992) instead of modulo-N. The same method is > employed by the IPv4 routing code since commit 0e884c78ee19 ("ipv4: L3 > hash-based multipath"). > > Unlike modulo-N, with hash-threshold only the flows near the region > boundaries are affected when a nexthop is added or removed. In addition, > it allows us to easily add support for non-equal-cost multipath in the > last patch by sizing the different regions according to the provided > weights. > > Ido Schimmel (4): > ipv6: Calculate hash thresholds for IPv6 nexthops > ipv6: Use a 31-bit multipath hash > ipv6: Use hash-threshold instead of modulo-N > ipv6: Add support for non-equal-cost multipath > > include/net/ip6_fib.h | 2 + > include/net/ip6_route.h | 7 +++ > net/ipv6/ip6_fib.c | 8 +-- > net/ipv6/route.c | 141 +++++++++++++++++++++++++++++++++++++++--------- > 4 files changed, 126 insertions(+), 32 deletions(-) > Also, have you considered support for sysctl_fib_multipath_hash_policy?