Re: [net-next 3/4] dt-bindings: net: ftgmac100: add rgmii delay properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/03/2025 03:59, Jacky Chou wrote:
> Add tx-internal-delay-ps and rx-internal-delay-ps to

Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).  However don't wrap blindly (see Kernel coding style).

> configure the RGMII delay for MAC. According to
> ethernet-controller.yaml, they use for RGMII TX and RX delay.
> 
> In Aspeed desgin, the RGMII delay is a number of ps as unit to
> set delay, do not use one ps as unit. The values are different
> from each MAC. So, here describes the property values
> as index to configure corresponding scu register.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---

...

>    mdio:
>      $ref: /schemas/net/mdio.yaml#
>  
> @@ -102,4 +116,4 @@ examples:
>                  reg = <1>;
>              };
>          };
> -    };
> +    };
> \ No newline at end of file


This was neither tested nor reviewed by you before sending.


Best regards,
Krzysztof