From: David Ahern <dsahern@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Tom Herbert <tom@herbertland.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net v2] ipv6: omit traffic class when calculating flow hash
Date: Sat, 2 Jun 2018 14:33:38 -0600 [thread overview]
Message-ID: <0d6c6732-ee1b-3533-fc06-f97c9a87eb1a@gmail.com> (raw)
In-Reply-To: <20180602080528.54B27A0C48@unicorn.suse.cz>
On 6/2/18 1:40 AM, Michal Kubecek wrote:
> Some of the code paths calculating flow hash for IPv6 use flowlabel member
> of struct flowi6 which, despite its name, encodes both flow label and
> traffic class. If traffic class changes within a TCP connection (as e.g.
> ssh does), ECMP route can switch between path. It's also incosistent with
> other code paths where ip6_flowlabel() (returning only flow label) is used
> to feed the key.
>
> Use only flow label everywhere, including one place where hash key is set
> using ip6_flowinfo().
>
> Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")
> Fixes: f70ea018da06 ("net: Add functions to get skb->hash based on flow structures")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
> v2: introduce and use an inline helper as suggested by David Ahern
>
> include/net/ipv6.h | 5 +++++
> net/core/flow_dissector.c | 2 +-
> net/ipv6/route.c | 4 ++--
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-06-02 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 7:40 [PATCH net v2] ipv6: omit traffic class when calculating flow hash Michal Kubecek
2018-06-02 9:39 ` Ido Schimmel
2018-06-02 20:33 ` David Ahern [this message]
2018-06-03 15:00 ` David Ahern
2018-06-04 9:36 ` [PATCH net v3] " Michal Kubecek
2018-06-04 17:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6c6732-ee1b-3533-fc06-f97c9a87eb1a@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).