From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EEA31FF60B for ; Thu, 20 Feb 2025 16:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740070514; cv=none; b=s45aPSZ3Fer6Ixvm3PJU/CCJELxmI5GzX8S4OxZM/1j/XDVghn7ngORi+NOEhJdNP6ejKoJZWSwuSNoi/a+vjrDnJlBp79hQUdEznApWa7cPtxarC906S2hxECZH1yPw6bSHcKTa5z0khi4AM+Apq8FO7L4KdLuuXsuUh/lTVhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740070514; c=relaxed/simple; bh=aEruYy9Jupi+QeIVYrobX1arErkFRLvPPiRVFuahcLs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dtuqqg47WVvHfch44j3x3zGtLbCPBP/TebpIrMeN7WVrUR9Sc/Or6OkP/wKXvdERAkSIY9qFv5U+WEj4ULoEpurLnO5nU7IiPh467TBQD4AmGUIxzqs1MFVaixUTJqhDVCElU9kDaSEXQvvQdozM+7rBAL8WNnDDT93x7iTSOU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jrRUZpVS; arc=none smtp.client-ip=91.218.175.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jrRUZpVS" Message-ID: <0d729331-fab0-4b59-8d58-ce22e99b269a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740070500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtG6ZjpAmeJKxNeyEoaFjSdFaIwdGa1v9iPU/FPE11Y=; b=jrRUZpVSLWy/ItsZGz27gX9dI3AuXjsM0KbdNPZSAfF81twYEgs2mk43kO3PqZb8aNm+Qo Ii0C2T4GKl/04TSRZW2ivhjG96n66eqmPWX+tge6PiwXVryAbsjn+f1Z4URT9G2+P15le7 t5G9+Eg4v2Yqjm1KCiNOClSuQy3QsaI= Date: Thu, 20 Feb 2025 11:53:23 -0500 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] net: cadence: macb: Implement BQL To: Jakub Kicinski Cc: Nicolas Ferre , Claudiu Beznea , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet References: <20250214211643.2617340-1-sean.anderson@linux.dev> <20250218175700.4493dc49@kernel.org> <10a50a6c-a6be-4723-80b3-62119f667977@linux.dev> <20250220085137.62360239@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250220085137.62360239@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2/20/25 11:51, Jakub Kicinski wrote: > On Thu, 20 Feb 2025 10:55:45 -0500 Sean Anderson wrote: >> On 2/18/25 20:57, Jakub Kicinski wrote: >> > On Fri, 14 Feb 2025 16:16:43 -0500 Sean Anderson wrote: >> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >> >> index 48496209fb16..63c65b4bb348 100644 >> >> --- a/drivers/net/ethernet/cadence/macb_main.c >> >> +++ b/drivers/net/ethernet/cadence/macb_main.c >> >> @@ -1081,6 +1081,9 @@ static void macb_tx_error_task(struct work_struct *work) >> >> tx_error_task); >> >> bool halt_timeout = false; >> >> struct macb *bp = queue->bp; >> >> + u32 queue_index = queue - bp->queues; >> > >> > nit: breaking reverse xmas tree here >> >> It has to happen here since bp isn't available earlier. > > Move it from init to normal code? That's what I ended up doing. --Sean