netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	netdev@vger.kernel.org, josh@joshtriplett.org
Subject: [PATCH 11/13] net: Move prototype declaration to header file include/net/net_namespace.h from net/ipx/af_ipx.c
Date: Sun, 9 Feb 2014 01:37:20 +0530	[thread overview]
Message-ID: <0d855fd121af07a77d258aec045b71dfa68cb0af.1391888654.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <6f029c895035908595957fb16ab445c82793c77d.1391888654.git.rashika.kheria@gmail.com>

Move prototype declaration of function to header file
include/net/net_namespace.h from net/ipx/af_ipx.c because they are used
by more than one file.

This eliminates the following warning in net/ipx/sysctl_net_ipx.c:
net/ipx/sysctl_net_ipx.c:33:6: warning: no previous prototype for ‘ipx_register_sysctl’ [-Wmissing-prototypes]
net/ipx/sysctl_net_ipx.c:38:6: warning: no previous prototype for ‘ipx_unregister_sysctl’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 include/net/net_namespace.h |    3 +++
 net/ipx/af_ipx.c            |    6 ++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index da68c9a..a43435c 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -162,6 +162,9 @@ extern struct list_head net_namespace_list;
 struct net *get_net_ns_by_pid(pid_t pid);
 struct net *get_net_ns_by_fd(int pid);
 
+void ipx_register_sysctl(void);
+void ipx_unregister_sysctl(void);
+
 #ifdef CONFIG_NET_NS
 void __put_net(struct net *net);
 
diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
index 224d058..aa2abb8 100644
--- a/net/ipx/af_ipx.c
+++ b/net/ipx/af_ipx.c
@@ -54,13 +54,11 @@
 #include <net/sock.h>
 #include <net/datalink.h>
 #include <net/tcp_states.h>
+#include <net/net_namespace.h>
 
 #include <asm/uaccess.h>
 
-#ifdef CONFIG_SYSCTL
-extern void ipx_register_sysctl(void);
-extern void ipx_unregister_sysctl(void);
-#else
+#ifndef CONFIG_SYSCTL
 #define ipx_register_sysctl()
 #define ipx_unregister_sysctl()
 #endif
-- 
1.7.9.5

  parent reply	other threads:[~2014-02-08 20:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 19:47 [PATCH 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-08 19:49 ` [PATCH 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-08 20:04   ` Josh Triplett
2014-02-08 19:51 ` [PATCH 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-08 20:04   ` Josh Triplett
2014-02-08 19:53 ` [PATCH 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-08 20:07   ` Josh Triplett
2014-02-08 21:18   ` Veaceslav Falico
2014-02-08 19:55 ` [PATCH 05/13] net: Mark function as static in core/filter.c Rashika Kheria
2014-02-08 20:09   ` Josh Triplett
2014-02-08 19:58 ` [PATCH 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-08 20:10   ` Josh Triplett
2014-02-08 19:59 ` [PATCH 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-08 20:11   ` Josh Triplett
2014-02-08 20:02 ` [PATCH 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-08 20:11   ` Josh Triplett
2014-02-08 20:03 ` [PATCH 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12   ` Josh Triplett
2014-02-08 20:04 ` [PATCH 01/13] net: Mark function as static in 9p/client.c Josh Triplett
2014-02-08 20:05 ` [PATCH 10/13] net: Move prototype declaration to header file include/net/datalink.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-08 20:12   ` Josh Triplett
2014-02-08 20:07 ` Rashika Kheria [this message]
2014-02-08 20:14   ` [PATCH 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Josh Triplett
2014-02-08 20:09 ` [PATCH 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
2014-02-08 20:14   ` Josh Triplett
2014-02-08 20:10 ` [PATCH 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
     [not found]   ` <259f3dc38d7115eccf3aaa2aa7de2414a47f90a2.1391888654.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-08 20:23     ` Josh Triplett
2014-02-11 17:12   ` J. Bruce Fields
2014-02-09 14:27 ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c Rashika Kheria
2014-02-09 14:29   ` [PATCH v2 02/13] net: Include appropriate header file in caif/caif_dev.c Rashika Kheria
2014-02-09 14:32   ` [PATCH v2 03/13] net: Include appropriate header file in caif/cfsrvl.c Rashika Kheria
2014-02-09 14:56   ` [PATCH v2 04/13] net: Mark functions as static in core/dev.c Rashika Kheria
2014-02-09 16:50   ` [PATCH v2 06/13] net: Move prototype declaration to appropriate header file from decnet/af_decnet.c Rashika Kheria
2014-02-09 16:52   ` [PATCH v2 07/13] net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c Rashika Kheria
2014-02-09 16:54   ` [PATCH v2 08/13] net: Move prototype declaration to include/net/ipx.h from net/ipx/ipx_route.c Rashika Kheria
2014-02-09 16:56   ` [PATCH v2 09/13] net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c Rashika Kheria
2014-02-09 16:57   ` [PATCH v2 10/13] net: Move prototype declaration to header file include/net/datalink.h " Rashika Kheria
2014-02-09 16:59   ` [PATCH v2 11/13] net: Move prototype declaration to header file include/net/net_namespace.h " Rashika Kheria
2014-02-09 17:01   ` [PATCH v2 12/13] net: Include appropriate header file in netfilter/nft_lookup.c Rashika Kheria
     [not found]   ` <6f029c895035908595957fb16ab445c82793c77d.1391955924.git.rashika.kheria-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-09 17:03     ` [PATCH v2 13/13] net: Mark functions as static in net/sunrpc/svc_xprt.c Rashika Kheria
2014-02-10  2:02   ` [PATCH v2 01/13] net: Mark function as static in 9p/client.c David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d855fd121af07a77d258aec045b71dfa68cb0af.1391888654.git.rashika.kheria@gmail.com \
    --to=rashika.kheria@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).