From: Andrew Lunn <andrew@lunn.ch>
To: Manush Prajwal <manushprajwal555@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: netcp_core: fix device_node refcount leak in netcp_probe()
Date: Thu, 13 Aug 2026 17:19:47 +0200 [thread overview]
Message-ID: <0daf39c9-d2de-46da-8cd4-09de13096f56@lunn.ch> (raw)
In-Reply-To: <20260813111058.500-1-manushprajwal555@gmail.com>
On Thu, Aug 13, 2026 at 04:40:58PM +0530, Manush Prajwal wrote:
> When netcp_create_interface() fails for a given child node,
> netcp_probe() jumps to probe_quit_interface, which releases the
> "interfaces" parent node but never the "child" node that the
> for_each_available_child_of_node() loop was iterating on.
Would for_each_available_child_of_node_scoped() work here?
Andrew
prev parent reply other threads:[~2026-08-13 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 11:10 [PATCH] net: ethernet: ti: netcp_core: fix device_node refcount leak in netcp_probe() Manush Prajwal
2026-08-13 15:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0daf39c9-d2de-46da-8cd4-09de13096f56@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=manushprajwal555@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox