From: Andrew Lunn <andrew@lunn.ch>
To: Ziyou Xu <xuziyougm@gmail.com>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, bjorn@mork.no,
ericwouds@gmail.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2] net: phy: air_en8811h: restore AN8811HB LED GPIO after MCU restart
Date: Fri, 28 Aug 2026 15:08:54 +0200 [thread overview]
Message-ID: <0db183d7-3881-4f81-9e04-cd2c13d1dcee@lunn.ch> (raw)
In-Reply-To: <20260828032922.469449-1-xuziyougm@gmail.com>
> @@ -1265,10 +1258,19 @@ static int an8811hb_config_init(struct phy_device *phydev)
>
> ret = air_leds_init(phydev, EN8811H_LED_COUNT, AIR_PHY_LED_DUR,
> AIR_LED_MODE_USER_DEFINE);
> - if (ret < 0)
> + if (ret < 0) {
> phydev_err(phydev, "Failed to initialize leds: %d\n", ret);
> + return ret;
> + }
>
> - return ret;
> + /* Restore LED GPIO output enables after MCU initialization. */
> + ret = air_phy_buckpbus_reg_modify(phydev, AN8811HB_GPIO_OUTPUT,
> + AN8811HB_GPIO_OUTPUT_345,
> + AN8811HB_GPIO_OUTPUT_345);
> + if (ret < 0)
> + return ret;
> +
> + return 0;
That can be squashed down to:
return ret;
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-08-28 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 3:29 [PATCH net v2] net: phy: air_en8811h: restore AN8811HB LED GPIO after MCU restart Ziyou Xu
2026-08-28 13:08 ` Andrew Lunn [this message]
2026-08-28 13:59 ` Ziyou Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db183d7-3881-4f81-9e04-cd2c13d1dcee@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xuziyougm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox