* [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency
@ 2017-08-01 11:50 Arnd Bergmann
2017-08-01 16:32 ` Florian Fainelli
2017-08-02 17:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-08-01 11:50 UTC (permalink / raw)
To: David S. Miller, Florian Fainelli
Cc: Arnd Bergmann, Michael Chan, Sathya Perla, netdev, linux-kernel
The last patch added the dependency on 'OF && HAS_IOMEM' but left
COMPILE_TEST as an alternative, which kind of defeats the purpose
of adding the dependency, we still get randconfig build warnings:
warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO)
For compile-testing purposes, we don't really need this anyway,
as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM
is present on all architectures we do meaningful compile-testing on
(the exception being arch/um).
This makes both OF and HAS_IOMEM hard dependencies.
Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 45775399cab6..1456cb18f830 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -61,7 +61,7 @@ config BCM63XX_ENET
config BCMGENET
tristate "Broadcom GENET internal MAC support"
- depends on (OF && HAS_IOMEM) || COMPILE_TEST
+ depends on OF && HAS_IOMEM
select MII
select PHYLIB
select FIXED_PHY
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency
2017-08-01 11:50 [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency Arnd Bergmann
@ 2017-08-01 16:32 ` Florian Fainelli
2017-08-02 17:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-08-01 16:32 UTC (permalink / raw)
To: Arnd Bergmann, David S. Miller
Cc: Michael Chan, Sathya Perla, netdev, linux-kernel
On 08/01/2017 04:50 AM, Arnd Bergmann wrote:
> The last patch added the dependency on 'OF && HAS_IOMEM' but left
> COMPILE_TEST as an alternative, which kind of defeats the purpose
> of adding the dependency, we still get randconfig build warnings:
>
> warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO)
>
> For compile-testing purposes, we don't really need this anyway,
> as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM
> is present on all architectures we do meaningful compile-testing on
> (the exception being arch/um).
>
> This makes both OF and HAS_IOMEM hard dependencies.
>
> Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency
2017-08-01 11:50 [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency Arnd Bergmann
2017-08-01 16:32 ` Florian Fainelli
@ 2017-08-02 17:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-02 17:42 UTC (permalink / raw)
To: arnd; +Cc: f.fainelli, michael.chan, sathya.perla, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 1 Aug 2017 13:50:56 +0200
> The last patch added the dependency on 'OF && HAS_IOMEM' but left
> COMPILE_TEST as an alternative, which kind of defeats the purpose
> of adding the dependency, we still get randconfig build warnings:
>
> warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO)
>
> For compile-testing purposes, we don't really need this anyway,
> as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM
> is present on all architectures we do meaningful compile-testing on
> (the exception being arch/um).
>
> This makes both OF and HAS_IOMEM hard dependencies.
>
> Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-02 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01 11:50 [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency Arnd Bergmann
2017-08-01 16:32 ` Florian Fainelli
2017-08-02 17:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).