From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF46C43381 for ; Sat, 16 Feb 2019 19:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E982222E0 for ; Sat, 16 Feb 2019 19:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAmPnA57" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729018AbfBPTkF (ORCPT ); Sat, 16 Feb 2019 14:40:05 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36848 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbfBPTkE (ORCPT ); Sat, 16 Feb 2019 14:40:04 -0500 Received: by mail-wm1-f65.google.com with SMTP id j125so12970876wmj.1 for ; Sat, 16 Feb 2019 11:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9fvum5Qw3qCZILfo5zGNufJjxdSqNS2WH1WSEoF00JU=; b=AAmPnA57YTUHI4Gi4EJMrNWGJoKPmjPw+7g3bJaWxToGfqdy5wVesmDKeW5WCu9+A2 z7W+DWAQ7xO/9N2CXrVwVq8mU3rxLRQqXxgmK+XHAsiTVhv2ll1W3/g3gzloJpsQWggF ggo5SGj2rV05tydGVxBW9OtsPvR6cULiI24NSeEFGb7+jMN8abnWdqDwMKFA3IRfHMVJ ugVJbf9+N4U6Xeef9LfGyUlm2KNOg+1CcosykWbo4IXllgNhKeelRP3jJRdHkImCKSef oPCexHx5yY/YRtqQJ9D5mRyQ4wn2h5CT1QNEXgWyaOx9wqcVFlOBCqEKaDmyotQpxE7C ERAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9fvum5Qw3qCZILfo5zGNufJjxdSqNS2WH1WSEoF00JU=; b=gqR5rVfRplP3uc9pctx9ozq2XVBcDbDqXytFcxalg+QcHuJ1cW3I9SaqrS3oUQNIam j0nmzsLsbYPsPyNHXBpnal4DUjHtVfd4irTGem62OumpREy2giKTBjCgaUXVb3GjpL+6 C3/ZI2l0ADDUe1mQK53jEM/J6/2rdJhTbbTUJPMUToObc0hFLDuM/tZ/DVQzMAGrbvqE 4+wsmnFGUmOCFONRnwJZg7fRoHvcukLiXGQr0GQ7JTQS+TTakIMyE/xdkiQ6T1KnSpTQ 738cyCKVLk5UWiSZBCuEGQnnwV9/L7cgeJisx1t/xdxWCdkbIaHivKGsJrFM1MdH/sZq tirw== X-Gm-Message-State: AHQUAubvrSF0QNR32h9mKlGd+0Zidkk9Xpz18fGHdkZ4pMZBom0M/7zd XwNUfBpPO1nUkPX2C9CdaIwKYNtu X-Google-Smtp-Source: AHgI3IaF1uwXcU2Sh7dixYqWoXTj6T/XEdc0Jw6SqpWrkSXpAXNYhcFRQYQs0qYYt29/hPoDiMHAxA== X-Received: by 2002:a1c:eb10:: with SMTP id j16mr9908620wmh.64.1550346002671; Sat, 16 Feb 2019 11:40:02 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc50:d076:bfa9:dffa? (p200300EA8BF1E200FC50D076BFA9DFFA.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc50:d076:bfa9:dffa]) by smtp.googlemail.com with ESMTPSA id t4sm7917245wrb.64.2019.02.16.11.40.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 11:40:01 -0800 (PST) Subject: Re: [PATCH net-next 1/2] net: phy: disable aneg in genphy_c45_pma_setup_forced To: Stefano Brivio Cc: Andrew Lunn , Florian Fainelli , David Miller , Russell King - ARM Linux , "netdev@vger.kernel.org" References: <8945c224-bfff-294d-f855-979016e077ec@gmail.com> <27bb134f-eb4e-e43a-5d9d-2c551a22428c@gmail.com> <20190216203120.06923d0c@redhat.com> From: Heiner Kallweit Message-ID: <0db62e74-a767-77f0-5e0b-48dd6b83f311@gmail.com> Date: Sat, 16 Feb 2019 20:39:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190216203120.06923d0c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.02.2019 20:31, Stefano Brivio wrote: > Hi, > > On Sat, 16 Feb 2019 20:10:24 +0100 > Heiner Kallweit wrote: > >> When genphy_c45_pma_setup_forced() is called the "aneg enabled" bit may >> still be set, therefore clear it. This is also in line with what >> genphy_setup_forced() does for Clause 22. >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/net/phy/phy-c45.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c >> index bef126344..0374c50b1 100644 >> --- a/drivers/net/phy/phy-c45.c >> +++ b/drivers/net/phy/phy-c45.c >> @@ -71,6 +71,10 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) >> return ret; >> >> return phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL2, ctrl2); >> + if (ret < 0) > > Perhaps you meant ret = phy_write_mmd(...)? > Ups, for sure I meant this. Strange that the compiler doesn't complain. >> + return ret; >> + >> + return genphy_c45_an_disable_aneg(phydev); >> } >> EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); >> > Heiner