From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Westergreen, Dalon" Subject: Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response Date: Sat, 17 Nov 2018 15:29:17 +0000 Message-ID: <0de0bb6fe59df5601105939036c33f12edc593e2.camel@intel.com> References: <20181115005047.28464-1-dwesterg@gmail.com> <20181115005047.28464-2-dwesterg@gmail.com> <20181116.203800.1372283941971325282.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-Z5UTTkoNLsE1+Tk5aqpZ" Cc: "netdev@vger.kernel.org" , "dinguyen@kernel.org" , "thor.thayer@linux.intel.com" To: "davem@davemloft.net" Return-path: Received: from mga01.intel.com ([192.55.52.88]:37392 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbeKRBqT (ORCPT ); Sat, 17 Nov 2018 20:46:19 -0500 In-Reply-To: <20181116.203800.1372283941971325282.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: --=-Z5UTTkoNLsE1+Tk5aqpZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2018-11-16 at 20:38 -0800, David Miller wrote: > From: Dalon Westergreen > Date: Wed, 14 Nov 2018 16:50:40 -0800 >=20 > > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv= , > struct tse_buffer *buffer) > > /* enqueue the request to the pending transmit queue */ > > queue_tx(priv, buffer); > > =20 > > - return 1; > > + return 0; >=20 > NETDEV_TX_OK. >=20 > And now you can make all of these functions properly return netdev_tx_t > instead of int. sure thing. --dalon --=-Z5UTTkoNLsE1+Tk5aqpZ Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKfTCCBOsw ggPToAMCAQICEDabxALowUBS+21KC0JI8fcwDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzEyMTEwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA yzuW/y/g0bznz8BD48M94luFzqHaqY9yGN9H/W0J7hOVBpl0rTQJ6kZ7z7hyDb9kf2UW4ZU25alC i+q5m6NwHg+z9pcN7bQ84SSBueaYF7cXlAg7z3XyZbzSEYP7raeuWRf5fYvYzq8/uI7VNR8o/43w PtDP10YDdO/0J5xrHxnC/9/aU+wTFSVsPqxsd7C58mnu7G4VRJ0n9PG4SfmYNC0h/5fLWuOWhxAv 6MuiK7MmvTPHLMclULgJqVSqG1MbBs0FbzoRHne4Cx0w6rtzPTrzo+bTRqhruaU18lQkzBk6OnyJ UthtaDQIlfyGy2IlZ5F6QEyjItbdKcHHdjBX8wIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFNpBI5xaj3GvV4M+INPjZdsMywvbMA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAp9XGgH85hk/3IuN8F4nrFd24MAoau7Uq M/of09XtyYg2dV0TIPqtxPZw4813r78WwsGIbvtO8VQ18dNktIxaq6+ym2zebqDh0z6Bvo63jKE/ HMj8oNV3ovnuo+7rGpCppcda4iVBG2CetB3WXbUVr82EzECN+wxmC4H9Rup+gn+t+qeBTaXulQfV TYOvZ0eZPO+DyC2pVv5q5+xHljyUsVqpzsw89utuO8ZYaMsQGBRuFGOncRLEOhCtehy5B5aCI571 i4dDAv9LPODrEzm3PBfrNhlp8C0skak15VXWFzNuHd00AsxXxWSUT4TG8RiAH61Ua5GXsP1BIZwl 4WjK8DCCBYowggRyoAMCAQICEzMAAFPRWYu6F7Q3qHcAAAAAU9EwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEIwHhcNMTcxMjA0MTQ1NDI4WhcNMTgxMTI5MTQ1NDI4WjBJMRswGQYDVQQDExJXZXN0ZXJn cmVlbiwgRGFsb24xKjAoBgkqhkiG9w0BCQEWG2RhbG9uLndlc3RlcmdyZWVuQGludGVsLmNvbTCC ASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAOkKYI60MbIuBU9nAIXlddSU2RXIdX5oGJfo IcjyCiheQzBJwsL9HKBJhOGOlBL7BLOxVX4791eN9uu9lCBWgWBNWZyZOWEyozmQz2gaPI0HbIhT l0sBV6zMcbe7yoXq8Crmtu3t17edx1XfO/bZFPAyFyat93XjCyMfwoM8SOPk4NK/RnTSJxno1BQP psyx/JaNzZ0ZJwJg0JEnMtzcE5+X0o29eIUyHEBsbdesBM+oaThfXWZ1mNaJ6xLQcOVZe6VI7/t6 YiZOpOmyYxYiWQv3T6fFdpULezzYnXb46QCT4Gt28sXSwt3SMKyp+6R/mfd6GZSVGJaGtM+xaAj4 VKMCAwEAAaOCAjkwggI1MB0GA1UdDgQWBBQj/3m4gOAsKxOnHO7AyEh+ji3WMzAfBgNVHSMEGDAW gBTaQSOcWo9xr1eDPiDT42XbDMsL2zBlBgNVHR8EXjBcMFqgWKBWhlRodHRwOi8vd3d3LmludGVs LmNvbS9yZXBvc2l0b3J5L0NSTC9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIw Q0ElMjA0Qi5jcmwwgZ8GCCsGAQUFBwEBBIGSMIGPMCIGCCsGAQUFBzABhhZodHRwOi8vb2NzcC5p bnRlbC5jb20vMGkGCCsGAQUFBzAChl1odHRwOi8vd3d3LmludGVsLmNvbS9yZXBvc2l0b3J5L2Nl cnRpZmljYXRlcy9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0Qi5j cnQwCwYDVR0PBAQDAgeAMDwGCSsGAQQBgjcVBwQvMC0GJSsGAQQBgjcVCIbDjHWEmeVRg/2BKIWO n1OCkcAJZ4HevTmV8EMCAWQCAQkwHwYDVR0lBBgwFgYIKwYBBQUHAwQGCisGAQQBgjcKAwwwKQYJ KwYBBAGCNxUKBBwwGjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgMMMFMGA1UdEQRMMEqgKwYKKwYB BAGCNxQCA6AdDBtkYWxvbi53ZXN0ZXJncmVlbkBpbnRlbC5jb22BG2RhbG9uLndlc3RlcmdyZWVu QGludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAddxGSWTDtP4opk9jnG1WIJv0cLeO10Gxvgu7 nzrOEwasvvCu/0/PT1L+44Nkf4RCtLSV5MmojqAi4WUqXPhcg18hlVTBjEqp2qkzhUgTx1HMbf00 dd382Jg1vRS2zhTU0X6LItmzx/1Vhpd2QBm4XNbdHlmar2Cs6RpmxCIO3Zn1fI+4dNz8Cw7/yn9t tC0q1ZGJe0WEf9bOBdpPBZtBR+Q1ayIop2blg+7IdVx0leqkQZEmW13r+Mpzx05BEQpiewBfhx0/ +07xwFCd1e0z/5SWEEn1n4FZy3RkycrZ2V6EcNlFXNX5/xOYGcWMLmLSIcICSE6uODR+TRWBYq3+ pTGCAhcwggITAgEBMIGQMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCAhMzAABT0VmLuhe0N6h3AAAAAFPRMAkGBSsOAwIaBQCg XTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xODExMTcxNTI5MTRa MCMGCSqGSIb3DQEJBDEWBBStMfYQQydv62PM1QlNFV+OQZyqpTANBgkqhkiG9w0BAQEFAASCAQC6 WE/9gzXQ4X43kk03z1qfto2ankP2qa20WdTotD4KzIYtqA9YLJtQiI6suEyGLV2M1arFzjNgdf+e M1abuTsID20m+d8yKwtUavxnoYia05OsriMBETsC6o/7ntQnnW0SEqQYH/cBUcoVb5QQ1Pf3dSJb zPanFi7pATIf5OaDqoK9g6+4m2ORB4wealeYWzfktzG7ABTK2AdebzEirFXqj+SwGvw3xeQ4jSxW N49E2Z/ROC/dGITROwmuVYgg6wFMlIfcBWxL9iXTna4fZt5YrPooG6Wnl7LCEypV75+22isISZjK 9fTNRRSJPxG/50iBkrcU39Ng/eZsNsuI0Uh1AAAAAAAA --=-Z5UTTkoNLsE1+Tk5aqpZ--