From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554C6C169C4 for ; Fri, 8 Feb 2019 23:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20541218DA for ; Fri, 8 Feb 2019 23:24:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rMrCtGRu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726699AbfBHXYO (ORCPT ); Fri, 8 Feb 2019 18:24:14 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:44484 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfBHXYN (ORCPT ); Fri, 8 Feb 2019 18:24:13 -0500 Received: by mail-pf1-f193.google.com with SMTP id u6so2361691pfh.11 for ; Fri, 08 Feb 2019 15:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WBVlEZa0zAgWrXnLxSFjv+6ZuW6dJfUFx1hNxGEmHf8=; b=rMrCtGRuDUNPnh9wfMoesmk92eL4A7kDei7iXR4UEq/Wt6UqRNbtsZURftpfDkuijl EHczWi+TXB3JwFsYgYQCOLlltl7lwJZTnYFM2LVjlcchKMJsQj3IdQG47xEoxMLsn5LP d5EgSyNbWfBsN2Z1C3K9uhpJq91uBiLIfxSfqG6KBDO1xc98vFfo8QX6XNLpdrIQGmEz F0xk9XcA4wfPe0VtNIByhPF4em+ohbcfgYr/62h3suG3NmE7Mm/6B9NsSNDV2FKk8UP4 SyZZyB5lho/As+OHai5knVt7/l9D949R0jF2fKytNLcj58OkmG82fQrH/DpOCC4Jq4mc R87A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WBVlEZa0zAgWrXnLxSFjv+6ZuW6dJfUFx1hNxGEmHf8=; b=q0/FspCzJt87/euhtjtMZCcf5+FDA5e1+21CojaHeNV07okGgMQpmt+3c3KIVqyHy4 v/pp+Q2NxCnyAJ3W4QXJrsrBQOxLrnGzGYAG0SbFhf7b5vzsSFRW2IoTmx4n/Fouyj7s PScp7sZf4kQSd2HDuiYWzXvQJEUjUewJHWseSJ9LEgVDaLTCXYEoyUFB9qC6O4tWhD0s gYttz63iukaJSDibHAOWZ4cNJe+XGmodnHw0R5WeSw6XP1FsBe5PLQrY2Sa3rWZPe8as 6WIVCxp3yO1fFmIUohdCrTE3UmsHhsoqKZsv2SEGKUL/WhFoV032DcVD/RXSq5LgTW7W 3LRg== X-Gm-Message-State: AHQUAubGnGpUlR6s7zTc7b5dxRdaUv7olRg/nHMnt1KHD4oxGVNfpdyU RmtTMyKG+UrJ3TL0/1qDyF8= X-Google-Smtp-Source: AHgI3IZgkuQ1XB+m9LQj+S4DTZElXTnL9ye9h14PgBLaOTiuHvjAI5uwMynZXPZpYXOlRn0aerwgBg== X-Received: by 2002:a63:2c8c:: with SMTP id s134mr21747578pgs.269.1549668253082; Fri, 08 Feb 2019 15:24:13 -0800 (PST) Received: from [10.40.10.131] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id b9sm4499680pfi.118.2019.02.08.15.24.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 15:24:12 -0800 (PST) Subject: Re: [PATCH bpf-next v8 4/6] bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c To: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org Cc: Peter Oskolkov , Willem de Bruijn References: <20190208163849.151626-1-posk@google.com> <20190208163849.151626-5-posk@google.com> From: David Ahern Message-ID: <0df7ab69-8215-1c83-ab3f-7802a4ffc5e3@gmail.com> Date: Fri, 8 Feb 2019 15:24:11 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190208163849.151626-5-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/8/19 8:38 AM, Peter Oskolkov wrote: > This patch builds on top of the previous patch in the patchset, > which added BPF_LWT_ENCAP_IP mode to bpf_lwt_push_encap. As the > encapping can result in the skb needing to go via a different > interface/route/dst, bpf programs can indicate this by returning > BPF_LWT_REROUTE, which triggers a new route lookup for the skb. > > v8 changes: fix kbuild errors when LWTUNNEL_BPF is builtin, but > IPV6 is a module: as LWTUNNEL_BPF can only be either Y or N, > call IPV6 routing functions only if they are built-in. you need to use the ipv6 stub to access v6 functionality when it is a module.