From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage Date: Tue, 18 Sep 2018 17:03:52 -0700 Message-ID: <0e0f3aa6-9b6e-edd5-226f-2e23de9b5a0f@gmail.com> References: <20180917233533.28626-1-ahs3@redhat.com> <20180917.193531.1424852853827678152.davem@davemloft.net> <4929e93d-508a-4670-9450-66e4fc85be7e@redhat.com> <29258606-8255-847c-b22f-8793999ce6fe@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "isubramanian@apm.com" , "kchudgar@apm.com" , "qnguyen@apm.com" To: Eric Dumazet , ahs3@redhat.com, "Lendacky, Thomas" , David Miller Return-path: In-Reply-To: <29258606-8255-847c-b22f-8793999ce6fe@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/18/2018 04:56 PM, Eric Dumazet wrote: > > > On 09/18/2018 04:27 PM, Eric Dumazet wrote: >> > >> I remember one of the napi_complete_done() change had to be reverted, >> for some obscure reason. > > > > That was not exactly a revert, : This is what I have so far for the drivers that both use napi_complete_done() without checking the return value and implement a ndo_poll_controller() callback: https://github.com/ffainelli/linux/commits/napi-check > > commit 129c6cda2de2a8ac44fab096152469999b727faf > Author: Eric Dumazet > Date: Mon Sep 18 13:03:43 2017 -0700 > > 8139too: revisit napi_complete_done() usage > > It seems we have to be more careful in napi_complete_done() > use. This patch is not a revert, as it seems we can > avoid bug that Ville reported by moving the napi_complete_done() > test in the spinlock section. > > Many thanks to Ville for detective work and all tests. > > Fixes: 617f01211baf ("8139too: use napi_complete_done()") > Reported-by: Ville Syrjälä > Tested-by: Ville Syrjälä > > Signed-off-by: David S. Miller > > > > > > -- Florian