Netdev List
 help / color / mirror / Atom feed
From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
To: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH 1/2] igc: Wait for MAC passthrough after reset
Date: Wed, 15 Jul 2026 10:57:04 +0300	[thread overview]
Message-ID: <0e28b9d1-ab9e-4934-b939-81557f6495b5@intel.com> (raw)
In-Reply-To: <alcd_FnUdrQug5cm@acelan-Precision-5480>

Hi AceLan,

>>> I wish we can detect if the MAC passthrough is enabled, so that we
>>> know if we need to poll for the MAC address.
>> Unfortunately, like you I am not aware of any way for the driver to know
>> whether MAC passthrough via FW is enabled. Because of this we have been
>> exploring a simpler way to support this feature via ACPI objects (which are
>> set by the BIOS when MAC passthrough is enabled and are easy for the driver
>> to query). I know some vendors have already implemented it, and I am
>> currently drafting a patch to send.
> Any good news about this patch?
The patch is here: 
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20260706/055944.html

I tested it on my setup with MAC passthrough enabled in the BIOS, with 
good results; no community feedback yet. I encourage you to try it. 
Lenovo and Dell laptops should have the capability.

>> The mechanism I have in mind does not require BIOS support - the I225/I226
>> FW already supports the required interrupt, AFAIK - it merely needs to be
>> enabled in the igc driver. With that said, there still remains the question
>> of how to notify the network stack above us that the MAC address has changed
>> post-probe - and whether it is even supported.
Looking at it again, this may not be as big of a deal as I feared. If we 
can call eth_hw_addr_set at any point in time to change the address, 
then we should be able to do this in a response to a FW interrupt. I can 
try to draft a patch for that, in parallel to collecting feedback on the 
ACPI approach. These are two different means to the same end, and some 
solutions may implement one but not the other.

--Dima

  reply	other threads:[~2026-07-15  7:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  7:33 [PATCH 1/2] igc: Wait for MAC passthrough after reset Chia-Lin Kao (AceLan)
2026-06-18  7:33 ` [PATCH 2/2] igc: Cache MAC passthrough address Chia-Lin Kao (AceLan)
2026-06-18  7:55 ` [Intel-wired-lan] [PATCH 1/2] igc: Wait for MAC passthrough after reset Loktionov, Aleksandr
2026-06-18  8:51   ` Ruinskiy, Dima
2026-06-22  1:57     ` Chia-Lin Kao (AceLan)
2026-06-22  8:54       ` Loktionov, Aleksandr
2026-06-29 16:42       ` Ruinskiy, Dima
2026-07-15  5:46         ` Chia-Lin Kao (AceLan)
2026-07-15  7:57           ` Ruinskiy, Dima [this message]
2026-06-18  8:08 ` Andrew Lunn
2026-06-18  8:49 ` [Intel-wired-lan] " Kwapulinski, Piotr
2026-06-18 10:11 ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e28b9d1-ab9e-4934-b939-81557f6495b5@intel.com \
    --to=dima.ruinskiy@intel.com \
    --cc=acelan.kao@canonical.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox