From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [bpf PATCH] bpf: selftest fix for sockmap Date: Wed, 13 Jun 2018 02:31:27 +0200 Message-ID: <0e4b873d-7e2d-7683-c7cb-0a0112d123a5@iogearbox.net> References: <20180611184735.31255.51105.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: John Fastabend , ast@kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:54240 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934688AbeFMAb3 (ORCPT ); Tue, 12 Jun 2018 20:31:29 -0400 In-Reply-To: <20180611184735.31255.51105.stgit@john-Precision-Tower-5810> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/11/2018 08:47 PM, John Fastabend wrote: > In selftest test_maps the sockmap test case attempts to add a socket > in listening state to the sockmap. This is no longer a valid operation > so it fails as expected. However, the test wrongly reports this as an > error now. Fix the test to avoid adding sockets in listening state. > > Fixes: 945ae430aa44 ("bpf: sockmap only allow ESTABLISHED sock state") > Signed-off-by: John Fastabend (fyi, discussed with John that this will be enrolled into the set of fixes he has pending for bpf since the test is related to the one restricting to ESTABLISHED state.)