From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3F9B33D8; Wed, 18 Dec 2024 00:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480567; cv=none; b=nFL0HTL3Cjj5s1ZhFpWztARLSfCf9g1E8GdbKX7leBhTQ/jUfl4V67RUzqiXOsHZuHh1+vL58jP1DsoXhGhoDmHwZUBuR8nCQcL76jfFiUbJezujzjhXMWIZcgzvpCSAeB+b3O7XxvvkZX11ggLWpb+y69UKQCy9kwdQ8ewrzPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480567; c=relaxed/simple; bh=9+cKn7QEeUDoB/RqtHyOeDf93MZ40cdw5taP99fDmLA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bJcTute60ZQ85OuCpHPBLrtOO+vVZq09WBUQH5j8E/X/e65Z1g5Jv3Jqk7pOi5G1uxd9CrHF9LAS4HQfTipc0nobi1ElnTkppLwx/3ddHlptBdq4pMxljD589Ss7/UlgOaTsx/Ym+33nfr8pl8MvtuFCvAur8RNXTWWCWpadgVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=TeGK7Yto; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="TeGK7Yto" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1734480562; bh=9+cKn7QEeUDoB/RqtHyOeDf93MZ40cdw5taP99fDmLA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=TeGK7YtofpEdTn+QXHIgNzR2pOGglZjJqbtojjMg1Tsmjx/tuyLs+ugkaW+dT6S+e j6mKVbwECq2s2WOMUKIH8Jr60sbHrY9yi3E42aXwpXp9dEcwAB1hW+Fn0RtusNilBw Tao/4iXfmANzhcix3jyFfW1pPtcNBLiUrojVFKp0lubuL/fCfBy7dpsGgoYD0ewEq6 dZqmjCvcUZ1Lhy/7+oWarxrJqYy0ju6LeD/MLuG55VK9JTel7887DfWH0hDvRIZ2q6 Kgh/SpPkma7La/XNv6Ik/+3gj/mOUgGKK/fEDVFXg6ASG/maJ62//SRYYCrXm5mfme A+1JrniUidSvA== Received: from [192.168.72.171] (210-10-213-150.per.static-ipl.aapt.com.au [210.10.213.150]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id A8FE26F531; Wed, 18 Dec 2024 08:09:20 +0800 (AWST) Message-ID: <0ea0aac339c2ee7522510f1dab5f69a27413434d.camel@codeconstruct.com.au> Subject: Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport From: Jeremy Kerr To: Joe Damato , admiyo@os.amperecomputing.com Cc: Matt Johnston , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Jonathan Cameron , Huisong Li Date: Wed, 18 Dec 2024 08:09:20 +0800 In-Reply-To: References: <20241217182528.108062-1-admiyo@os.amperecomputing.com> <20241217182528.108062-2-admiyo@os.amperecomputing.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Joe, > I suspect what Jeremy meant (but please feel free to correct me if > I'm mistaken, Jeremy) was that you may want to use the helpers in: >=20 > include/linux/netdevice.h No, I was just referring to the new(-ish) dstats infrastructure in the core, with dstats collection in rtnl_link_stats64() as of 94b601bc. However, your suggestion of: > =C2=A0 dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len); > =C2=A0 dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev); make it even simpler! I would agree with the recommendation there. Cheers, Jeremy