Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

Joe Damato
2024-12-18T18:17:10Z

On Wed, Dec 18, 2024 at 11:23:06AM -0500, Adam Young wrote:
>
> On 12/17/24 14:04, Joe Damato wrote:

[...]

> >
> > > + u64_stats_update_end(&dstats->syncp);
> > > + return;
> > > + }
> > > + if (!skb) {
> > > + u64_stats_inc(&dstats->rx_drops);
> > > + u64_stats_update_end(&dstats->syncp);
> > > + return;
> > > + }
> > > + u64_stats_inc(&dstats->rx_packets);
> > > + u64_stats_add(&dstats->rx_bytes, data_len);
> > > + u64_stats_update_end(&dstats->syncp);
> > I suspect what Jeremy meant (but please feel free to correct me if
> > I'm mistaken, Jeremy) was that you may want to use the helpers in:
> >
> > include/linux/netdevice.h
> >
> > e.g.
> >
> > dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len);
> > dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev);
> >
> > etc.
>
> I don't see those function calls in the 6.13-rc3 tree I am working with.
> Are they coming later?

If you are adding new code you should target net-next/main, which
has commit 18eabadd73ae ("vrf: Make pcpu_dstats update functions
available to other modules.") which adds those functions.

Have you rebased recently? Maybe your local clone of the tree is
stale?

FWIW: you can use `git format-patch --base=auto ...` to include base
tree information which can be helpful for identifying issues like
the above.