From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8AE3ACA7B for ; Tue, 20 Jan 2026 23:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768952666; cv=none; b=jwnJrntxN0HQW+sK5QYSDt/4pajRMCxnslnzoDndN2r/jdbSuf2cXIHZeMqfOgczLWyDihtE7ywTIAXRptPYKPyC6G9UNWMjr+QfOfAkuzS/VYTTfj5Q0qJGmGshrW3IOczXY++fSw/aeaj4Nt/WkIsTp+iNMsu9UQuEKgnzmKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768952666; c=relaxed/simple; bh=9me34u4oy/zI6wHNONKKIlR5rlAKTeUeC7SYhIdygYc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bfbhUzBSNrq9mlv2rLP8XRqSfpNKXC/35jBqlRXsUwSiljWqlvlri+AjonR+iJ5Zw8QDJA/cEZlVIAG1GJcjQQH4D6iK13EHHv3PMtkYDzRXFd4HiieYimlrGSz44Xu7lPJejaE+SHKA5U7/NfP3UPwn+/PE95iDJ7J3Xp4jEhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=AOiXflXT; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="AOiXflXT" Message-ID: <0ea85474-d3ce-42c3-8360-1a53eb456879@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768952662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KGA5b+grVZQoCK86vVDs2zAsKuW4vEnEne22G7ph12k=; b=AOiXflXTbsQOYq3ho0mJCb7oHPfkAW5HuuGcO6gEUAVdCamKYibEXW0oaSaE1seFkTsFdQ OqvoFt52HJ24mnBu06P7QCu249FNZTOOQGtW4Y6mII9N7Xb3hCyrJ7EqdL0PVOITVOkOol K8MKYtDSyPzwMso2C8mF+2leVw3OMj4= Date: Tue, 20 Jan 2026 15:44:15 -0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next 1/4] bpf, verifier: Support direct helper calls from prologue/epilogue To: Jakub Sitnicki Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Amery Hung , netdev@vger.kernel.org, kernel-team@cloudflare.com, bpf@vger.kernel.org References: <20260119-skb-meta-bpf-emit-call-from-prologue-v1-0-e8b88d6430d8@cloudflare.com> <20260119-skb-meta-bpf-emit-call-from-prologue-v1-1-e8b88d6430d8@cloudflare.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20260119-skb-meta-bpf-emit-call-from-prologue-v1-1-e8b88d6430d8@cloudflare.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/19/26 11:53 AM, Jakub Sitnicki wrote: > Prepare to remove support for calling kfuncs from prologue & epilogue. > > Instead allow direct helpers calls using BPF_EMIT_CALL. Such calls already > contain helper offset relative to __bpf_call_base and must bypass the > verifier's patch_call_imm fixup, which expects BPF helper IDs rather than a > pre-resolved offsets. > > Add a finalized_call flag to bpf_insn_aux_data to mark call instructions > with resolved offsets so the verifier can skip patch_call_imm fixup for > these calls. > > Note that the target of BPF_EMIT_CALL should be wrapped with BPF_CALL_x to > prevent an ABI mismatch between BPF and C on 32-bit architectures. Acked-by: Martin KaFai Lau