From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
"'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Jacob Keller'" <jacob.e.keller@intel.com>,
"'Kees Cook'" <kees@kernel.org>,
"'Chenguang Zhao'" <zhaochenguang@kylinos.cn>,
"'Russell King \(Oracle\)'" <rmk+kernel@armlinux.org.uk>,
"'Maciej Fijalkowski'" <maciej.fijalkowski@intel.com>,
"'Simon Horman'" <horms@kernel.org>
Subject: RE: [PATCH net v2 1/3] net: libwx: keep NGBE OCP cards MAC enabled
Date: Thu, 8 Oct 2026 10:19:13 +0800 [thread overview]
Message-ID: <0eac01dd56cb$698a3d00$3c9eb700$@trustnetic.com> (raw)
In-Reply-To: <20260929184852.364dd9e6@kernel.org>
On Wed, Sep 30, 2026 9:49 AM, Jakub Kicinski wrote:
> On Thu, 24 Sep 2026 10:01:47 +0800 Jiawen Wu wrote:
> > if (!(((wx->subsystem_device_id & WX_NCSI_MASK) == WX_NCSI_SUP) ||
> > - ((wx->subsystem_device_id & WX_WOL_MASK) == WX_WOL_SUP))) {
> > + ((wx->subsystem_device_id & WX_WOL_MASK) == WX_WOL_SUP) ||
> > + (wx->mac.type == wx_mac_em && (wx->subsystem_device_id & 0xFF) == 0x40))) {
>
> This condition looks way too magical for upstream
>
> Add some wx_has_ncsi() helper and add it there?
> At least then the meaning is clear, here it's next to WOL, no idea what
> it's supposed to mean.
I had planned to fix this issue temporarily, and unify to use 'wx->ncsi_enabled'
in a later net-next patch. Looks like I'm messing things up. I'll fix it all in V3.
next prev parent reply other threads:[~2026-10-08 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 2:01 [PATCH net v2 0/3] net: wangxun: keep MAC enabled for specific Jiawen Wu
2026-09-24 2:01 ` [PATCH net v2 1/3] net: libwx: keep NGBE OCP cards MAC enabled Jiawen Wu
2026-09-30 1:48 ` Jakub Kicinski
2026-10-08 2:19 ` Jiawen Wu [this message]
2026-09-24 2:01 ` [PATCH net v2 2/3] net: txgbe: keep MAC enabled for SP devices that support NCSI Jiawen Wu
2026-09-28 2:28 ` netdev-bot+sashiko
2026-09-24 2:01 ` [PATCH net v2 3/3] net: txgbe: keep MAC enabled for AML " Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0eac01dd56cb$698a3d00$3c9eb700$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox