From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C868EC282E0 for ; Fri, 19 Apr 2019 18:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99254222D9 for ; Fri, 19 Apr 2019 18:20:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DVjvC94i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfDSSUi (ORCPT ); Fri, 19 Apr 2019 14:20:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:38097 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbfDSSUh (ORCPT ); Fri, 19 Apr 2019 14:20:37 -0400 Received: by mail-pf1-f195.google.com with SMTP id 10so2880191pfo.5 for ; Fri, 19 Apr 2019 11:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g25/vqjuO7LA5OX/4vZNMFj2qz4UV7XYCbFfaHDm65w=; b=DVjvC94iADpDTnSOhDTIsuT9jpF+qPgorTRX83XbgHOcX1UBUUaVsSjLgC4VM0li9d Um9PYViTtR8cNyncaaRbzee5y+j9NoIS8FDFb5IiU6U7jOKbyppCSmsLmbH5c+Txp+IF +W+26aRhm3jAgJY5lJ2xzHD9wjn2ygaNBVY5O/JYjWYNLotovM6gwMOg+qOZ1jJo+XZh drMT70qB1Rq4X0eT6PCLcHgKCh5gWgbq//Bh+fGBMoPfQ9X/fUqzk4kFmtBdEpdxyBXF KuwcjaK7Zae5JFD39+YFYOQQdih6hgakI0DrJaZa/rehESwzjVVPspEN3XllF99F1Zn2 DCYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g25/vqjuO7LA5OX/4vZNMFj2qz4UV7XYCbFfaHDm65w=; b=e3D7HWBpAOutxCguIaFG3r0460xZ44YgE4P/dMt+r0tDTsVzJjFGAUHeVPilbtz2vW exXgdbQsYMABWY34vcRBcGZInaFKVUBrI8TxMJc8xstagaAbM6Shfb/uB/xHHe4ZyWK2 ZXi8ekEgJEmT1xK1oTJHfgtD1z2xO4B1VRwGtYFXdEmdLgLuj1giGwuTAddR+1go3bx7 kTE77rqwBnUDXPggxkN6swrxclx+dby17emVVvA31vn5FwMl/d8VGGAx74CHh91Fx0Gd oeP8QM/vOe+cnhviL3w6d5eoH8mxHklPkfoN3gLcc8W0mRg2FhyHhcFbJP8vuWtgfy/b jPCg== X-Gm-Message-State: APjAAAUZcYnfqQb9kzuGSXjRLUotU8IYDJuNZoxtQwNuwUe0HCVIoasO b+k07fgga9l4hKoYckcogaQKTlEB X-Google-Smtp-Source: APXvYqz2F/UaGMcbfZsN8cOQpeBgl2e9FMOJMsZGjId2YgqZh/V5aC154KCnfOoYENUKLzl16SSECw== X-Received: by 2002:a65:5184:: with SMTP id h4mr4462023pgq.109.1555687966062; Fri, 19 Apr 2019 08:32:46 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id d15sm6796042pfo.34.2019.04.19.08.32.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 08:32:45 -0700 (PDT) Subject: Re: [PATCH net-next 11/15] dsa: Add stub tag driver put method To: Andrew Lunn , David Miller Cc: netdev , Vivien Didelot References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-12-andrew@lunn.ch> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <0eaf546e-7658-51bd-6621-4e7cbc06c53a@gmail.com> Date: Fri, 19 Apr 2019 08:32:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418023120.17067-12-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/17/2019 7:31 PM, Andrew Lunn wrote: > When a DSA switch driver is unloaded, the lock on the tag driver > should be released so the module can be unloaded. Add the needed calls, > but leave the actual relase code as a stub. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index ba91bda8bdd3..efc51a9dc9c8 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -335,6 +335,8 @@ static void dsa_port_teardown(struct dsa_port *dp) > case DSA_PORT_TYPE_UNUSED: > break; > case DSA_PORT_TYPE_CPU: > + dsa_tag_driver_put(dp->tag_ops); > + /* fall thought */ Typo: s/fall thought/fall through/ Reviewed-by: Florian Fainelli -- Florian