From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling Date: Fri, 9 Nov 2018 12:19:01 -0800 Message-ID: <0eb505a6-8cf9-3392-ee9d-9778b67a305e@gmail.com> References: <63a44097-c37d-eb0f-98c8-2c1fefd1f246@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Heiner Kallweit , Andrew Lunn , David Miller Return-path: Received: from mail-yb1-f195.google.com ([209.85.219.195]:43573 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725752AbeKJGBO (ORCPT ); Sat, 10 Nov 2018 01:01:14 -0500 Received: by mail-yb1-f195.google.com with SMTP id h187-v6so1545670ybg.10 for ; Fri, 09 Nov 2018 12:19:05 -0800 (PST) In-Reply-To: <63a44097-c37d-eb0f-98c8-2c1fefd1f246@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/9/18 9:35 AM, Heiner Kallweit wrote: > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with this member in a way that it's clear we're > dealing with a bool value. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli -- Florian