From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A74C43381 for ; Sun, 31 Mar 2019 17:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74F992082C for ; Sun, 31 Mar 2019 17:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gw+qQqfN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731283AbfCaRyX (ORCPT ); Sun, 31 Mar 2019 13:54:23 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33290 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731228AbfCaRyX (ORCPT ); Sun, 31 Mar 2019 13:54:23 -0400 Received: by mail-wr1-f65.google.com with SMTP id q1so8924262wrp.0 for ; Sun, 31 Mar 2019 10:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YM6ETXGlUuoG+mtROzHR+YkhF6DZZiBF+z1ympNkHV4=; b=gw+qQqfNsj7eWJmY461F60LW3Dg1kGQaw/e+fsrYG6H7VayIl3DGWJhY6DLyViJz4l 0NMLHzLtolM5Tg+tiFHlwanhq9l4aidiq93FC2UfN/Ek46RQ6JkXM/8od+9IvV1K99wa hNRwYnbPPiG306gcrZcwDaPIVLS6BuZcCbjBG3kIATT2NdhifV8Yy+a4Y6JzVOxoSv8j GU2vsZbqpsnEp6/e2NfwRt8+U5eckURez2vIfNti2BFj9cUurlbrLlrnvgqA7RdTpM5r CIJzMIjRLytJllQ/xZ/yTj3kfeFf20cH5udNvrtNYxGW8RsdAmLOesmIx4phosXL5qem 3M8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YM6ETXGlUuoG+mtROzHR+YkhF6DZZiBF+z1ympNkHV4=; b=hYuSCXInvPc86+MpalYV1bfr4637w18xwOSGlRp2xON42tJBVE0O0sN0LrjpODctjF OIbhhAnk2wHIgB0Bc/ek4wcKz/0uyfa8OuserPZG+wInaVhsnpv/6Nk/Yy+42G9A/zTP eEmMhT2dim1vDU/EUod0VCoz94LizeoM/XXvn3f3LBQKzVzN9EdxVlHLarTo0gk3Rb6s 5csogYnMRTNytO8DNFh7/rtRqIRlXzAHGZAkeCYn0/mtWGaDtEoBSJyg5vNe35jGoDXE oMFatwyumZox24J432KiX+A17VIAUBiMIh8Mx/2DxQtVahHAFAXrvjdFSi+mKz80YeXI Igjw== X-Gm-Message-State: APjAAAViSm7eIbem1gKwA7tlNItZNAQFbogfCqQLJezk94PFpqkcbHUF DQ0SOvfp1R8mxdhBtAszsf89Fbxj X-Google-Smtp-Source: APXvYqyuSjzelIrE06xZHmOkSlKdlnZLfrYAa5hFj1mgauZelAL7OmcgTd+02umSVRx40SkKhE7SAw== X-Received: by 2002:adf:fe4d:: with SMTP id m13mr35333600wrs.267.1554054861242; Sun, 31 Mar 2019 10:54:21 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:a4e7:3af3:db88:50bb? (p200300EA8BE1DD00A4E73AF3DB8850BB.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:a4e7:3af3:db88:50bb]) by smtp.googlemail.com with ESMTPSA id t15sm11657665wmt.2.2019.03.31.10.54.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 10:54:20 -0700 (PDT) Subject: [PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: Message-ID: <0eba5bda-62c1-711e-12b5-1d71593ffad8@gmail.com> Date: Sun, 31 Mar 2019 19:52:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently mii_lpa_mod_linkmode_lpa_t() checks bit LPA_LPACK to detect whether link partner supports autoneg. This doesn't work correctly at least on Aquantia AQCS109 when it negotiates 1000Base-T2 mode. The "link partner is autoneg-capable" bit as defined by clause 45 is set however. Better let's switch in general to use the clause 45 standard for link partner autoneg detection. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 9e24d9569..666fbb0ee 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -262,12 +262,19 @@ int genphy_c45_read_lpa(struct phy_device *phydev) { int val; + val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_STAT1); + if (val < 0) + return val; + + linkmode_mod_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->lp_advertising, + val & MDIO_AN_STAT1_LPABLE); + /* Read the link partner's base page advertisement */ val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_LPA); if (val < 0) return val; - mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, val); + mii_adv_mod_linkmode_adv_t(phydev->lp_advertising, val); phydev->pause = val & LPA_PAUSE_CAP ? 1 : 0; phydev->asym_pause = val & LPA_PAUSE_ASYM ? 1 : 0; -- 2.21.0