From: Eric Dumazet <eric.dumazet@gmail.com>
To: GhantaKrishnamurthy MohanKrishna
<mohan.krishna.ghanta.krishnamurthy@ericsson.com>,
tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com,
maloy@donjonn.com, ying.xue@windriver.com,
netdev@vger.kernel.org, davem@davemloft.net
Cc: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@gmail.com>
Subject: Re: [net-next 2/3] tipc: implement socket diagnostics for AF_TIPC
Date: Fri, 29 Jun 2018 06:57:56 -0700 [thread overview]
Message-ID: <0ec77195-241f-44b2-cf69-60553fc2592f@gmail.com> (raw)
In-Reply-To: <1521639465-3169-3-git-send-email-mohan.krishna.ghanta.krishnamurthy@ericsson.com>
On 03/21/2018 06:37 AM, GhantaKrishnamurthy MohanKrishna wrote:
> This commit adds socket diagnostics capability for AF_TIPC in netlink
> family NETLINK_SOCK_DIAG in a new kernel module (diag.ko).
...
> +static u64 __tipc_diag_gen_cookie(struct sock *sk)
> +{
> + u32 res[2];
> +
> + sock_diag_save_cookie(sk, res);
> + return *((u64 *)res);
> +}
I am pretty sure some combination of compiler / arch could be not happy
with this assumption that res[] is aligned to allow an u64 to be read like that.
next prev parent reply other threads:[~2018-06-29 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 13:37 [net-next 0/3] tipc: socket diagnostics additions for AF_TIPC GhantaKrishnamurthy MohanKrishna
2018-03-21 13:37 ` [net-next 1/3] tipc: modify socket iterator for sock_diag GhantaKrishnamurthy MohanKrishna
2018-03-21 13:37 ` [net-next 2/3] tipc: implement socket diagnostics for AF_TIPC GhantaKrishnamurthy MohanKrishna
2018-06-29 13:57 ` Eric Dumazet [this message]
2018-06-29 15:03 ` Jon Maloy
2018-03-21 13:37 ` [net-next 3/3] tipc: step sk->sk_drops when rcv buffer is full GhantaKrishnamurthy MohanKrishna
2018-03-22 18:44 ` [net-next 0/3] tipc: socket diagnostics additions for AF_TIPC David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec77195-241f-44b2-cf69-60553fc2592f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=parthasarathy.bhuvaragan@gmail.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).