Re: [PATCH v2 1/2] drm/drm_ras: Add drm_ras netlink error event

["Tauro, Riana" <riana.tauro@intel.com>]

On 18-06-2026 15:36, Raag Jadav wrote:
> On Thu, Jun 11, 2026 at 10:51:46AM +0530, Riana Tauro wrote:
>> Define a new netlink event 'error-event' and a new multicast group
>> 'error-notify' in drm_ras. Each event contains device name, node and
>> error information to identify the error triggering the event.
>>
>> Add drm_ras_nl_error_event() to trigger an event from the driver.
>> Userspace must subscribe to 'error-notify' to receive 'error-event'
>> notifications.
>>
>> Usage:
>>
>> $ sudo ynl --family drm_ras --subscribe error-notify
> ...
>
>>   operations:
>>     list:
>> @@ -124,3 +151,24 @@ operations:
>>         do:
>>           request:
>>             attributes: *id-attrs
>> +    -
>> +      name: error-event
>> +      doc: >-
>> +           Notify userspace of an error event.
>> +           The event includes the device, node and error information
>> +           of the error that triggered the event.
>> +      attribute-set: error-event-attrs
>> +      mcgrp: error-notify
> This looks much closer to "notify:" property, which IIUC it's not. Looking
> at some of the existing examples, a better name could be something like
> 'error-monitor' or 'error-report' to make it a bit distinguishable.

Yeah makes sense.  Will change the group name
Thank you for the review :)

Thanks
Riana

>
> Or perhaps it could be just me without the coffee :(
> so I'll leave it to you.
>
> Reviewed-by: Raag Jadav <raag.jadav@intel.com>
>
>> +      event:
>> +        attributes:
>> +          - device-name
>> +          - node-id
>> +          - node-name
>> +          - error-id
>> +          - error-name
>> +          - error-value
>> +
>> +mcast-groups:
>> +  list:
>> +    -
>> +      name: error-notify