Netdev List
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Paolo Abeni <pabeni@redhat.com>,
	Matt Johnston <matt@codeconstruct.com.au>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet	 <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Greg Kroah-Hartman	 <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next v4 11/12] net: mctp: usb: enable v1.1 packet spanning
Date: Fri, 24 Jul 2026 13:12:16 +0800	[thread overview]
Message-ID: <0eeb9e53e5fdf2a505a371e413b825e6ceb7ef52.camel@codeconstruct.com.au> (raw)
In-Reply-To: <14455fa9-15b8-424d-aac0-b74d7da35f04@redhat.com>

Hi Paolo,

> Sashiko has still something to say:
> 
> https://sashiko.dev/#/patchset/20260713-dev-mctp-usb-1-1-v4-0-4ae8de764a01%40codeconstruct.com.au
> 
> and the race in look real to me.

Not so much a race, but more an inconsistency in how we're dealing with
ndo_stop between a deferred requeue vs urb kill. Fix coming in v5.

... and I may as well deal with non-power-of-two xfer sizes there too.

> Note that you are expected to act on AI review feedback autonomously,
> either debating it or addressing. A reply on the ML is expected in
> either cases.

Sure thing.

Cheers,


Jeremy

  reply	other threads:[~2026-07-24  5:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 14:32 [PATCH net-next v4 00/12] net: mctp: usb: Add support for MCTP-over-USB v1.1 Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 01/12] net: mctp: usb: Include version indicator in max packet size defines Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 02/12] net: mctp: usb: Use packet-length max for maximum packet-size check Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 03/12] net: mctp: usblib: Move RX transfer processing to a new mctp-usblib Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 04/12] net: mctp: usb: Improve IN endpoint status handling Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 05/12] net: mctp: usblib: Move TX transfer processing to mctp-usblib Jeremy Kerr
2026-07-13 14:32 ` [PATCH net-next v4 06/12] net: mctp: usblib: Add support for multi-packet transmit Jeremy Kerr
2026-07-13 14:33 ` [PATCH net-next v4 07/12] net: mctp: usb: Accommodate DSP0283 v1.1 header format Jeremy Kerr
2026-07-13 14:33 ` [PATCH net-next v4 08/12] net: mctp: usblib: Implement receive-side packet spanning Jeremy Kerr
2026-07-13 14:33 ` [PATCH net-next v4 09/12] net: mctp: usblib: Implement transmit-side " Jeremy Kerr
2026-07-13 14:33 ` [PATCH net-next v4 10/12] net: mctp: usblib: Add initial kunit tests Jeremy Kerr
2026-07-13 14:33 ` [PATCH net-next v4 11/12] net: mctp: usb: enable v1.1 packet spanning Jeremy Kerr
2026-07-23 11:25   ` Paolo Abeni
2026-07-24  5:12     ` Jeremy Kerr [this message]
2026-07-13 14:33 ` [PATCH net-next v4 12/12] net: mctp: usb: Allow multiple urbs in flight Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eeb9e53e5fdf2a505a371e413b825e6ceb7ef52.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox