From: Paolo Abeni <pabeni@redhat.com>
To: Steen Hegelund <steen.hegelund@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: UNGLinuxDriver@microchip.com,
Randy Dunlap <rdunlap@infradead.org>,
Casper Andersson <casper.casan@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Wan Jiabing <wanjiabing@vivo.com>,
Nathan Huckleberry <nhuck@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Daniel Machon <daniel.machon@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net 0/8] Add support for two classes of VCAP rules
Date: Thu, 22 Dec 2022 15:22:10 +0100 [thread overview]
Message-ID: <0efd4a7072fb90cc9bc9992b00d9ade233a38de1.camel@redhat.com> (raw)
In-Reply-To: <20221221132517.2699698-1-steen.hegelund@microchip.com>
Hello,
On Wed, 2022-12-21 at 14:25 +0100, Steen Hegelund wrote:
> This adds support for two classes of VCAP rules:
>
> - Permanent rules (added e.g. for PTP support)
> - TC user rules (added by the TC userspace tool)
>
> For this to work the VCAP Loopups must be enabled from boot, so that the
> "internal" clients like PTP can add rules that are always active.
>
> When the TC tool add a flower filter the VCAP rule corresponding to this
> filter will be disabled (kept in memory) until a TC matchall filter creates
> a link from chain 0 to the chain (lookup) where the flower filter was
> added.
>
> When the flower filter is enabled it will be written to the appropriate
> VCAP lookup and become active in HW.
>
> Likewise the flower filter will be disabled if there is no link from chain
> 0 to the chain of the filter (lookup), and when that happens the
> corresponding VCAP rule will be read from the VCAP instance and stored in
> memory until it is deleted or enabled again.
Despite the 'net' target, this looks really like net-next material as
most patches look like large refactor. I see there are a bunch of fixes
in patches 3-8, but quite frankly it's not obvious at all what the
refactors/new features described into the commit messages themself
really fix.
I suggest to move this series to net-next (and thus repost after Jan
2), unless you come-up with some good reasons to keep it in net.
Thanks,
Paolo
next prev parent reply other threads:[~2022-12-22 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 13:25 [PATCH net 0/8] Add support for two classes of VCAP rules Steen Hegelund
2022-12-21 13:25 ` [PATCH net 1/8] net: microchip: vcap api: Erase VCAP cache before encoding rule Steen Hegelund
2022-12-21 13:25 ` [PATCH net 2/8] net: microchip: sparx5: Reset VCAP counter for new rules Steen Hegelund
2022-12-21 13:25 ` [PATCH net 3/8] net: microchip: vcap api: Always enable VCAP lookups Steen Hegelund
2022-12-21 13:25 ` [PATCH net 4/8] net: microchip: vcap api: Convert multi-word keys/actions when encoding Steen Hegelund
2022-12-21 13:25 ` [PATCH net 5/8] net: microchip: vcap api: Use src and dst chain id to chain VCAP lookups Steen Hegelund
2022-12-21 13:25 ` [PATCH net 6/8] net: microchip: vcap api: Check chains when adding a tc flower filter Steen Hegelund
2022-12-21 13:25 ` [PATCH net 7/8] net: microchip: vcap api: Add a storage state to a VCAP rule Steen Hegelund
2022-12-21 13:25 ` [PATCH net 8/8] net: microchip: vcap api: Enable/Disable rules via chains in VCAP HW Steen Hegelund
2022-12-22 14:22 ` Paolo Abeni [this message]
2022-12-22 15:02 ` [PATCH net 0/8] Add support for two classes of VCAP rules Steen Hegelund
2022-12-22 16:12 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0efd4a7072fb90cc9bc9992b00d9ade233a38de1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=casper.casan@gmail.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=steen.hegelund@microchip.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox