From: Edward Cree <ecree.xilinx@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>,
Arnd Bergmann <arnd@kernel.org>,
Martin Habets <habetsm.xilinx@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-net-drivers@amd.com" <linux-net-drivers@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] sfc: selftest: fix struct packing
Date: Fri, 23 Jun 2023 13:57:39 +0100 [thread overview]
Message-ID: <0f12f612-7fad-59c6-c7dd-dea49721842b@gmail.com> (raw)
In-Reply-To: <ee0cf01638074abfbddda7edd3074d2c@AcuMS.aculab.com>
On 23/06/2023 11:52, David Laight wrote:
> Maybe you can get away with adding a 16bit pad before the ethernet
> header so that the IP header is actually aligned.
That's what I ended up doing, because my original idea was
overcomplicated and turned out super ugly.
See https://lore.kernel.org/netdev/6f87fdf5-1844-4633-b4fe-6b247bc6ab49@app.fastmail.com/T/
> (Then fight all the stuff that stops you doing a memcpy()
> that runs into a second field of a structure.)
Yeah, I don't know how you're meant to annotate that stuff.
I guess I'll have to wait until Kees shouts at me and tells
me what to do :S
-ed
next prev parent reply other threads:[~2023-06-23 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 9:12 [PATCH 1/3] [v2] sfc: add CONFIG_INET dependency for TC offload Arnd Bergmann
2023-06-19 9:12 ` [PATCH 2/3] [v2] sfc: fix uninitialized variable use Arnd Bergmann
2023-06-19 10:06 ` Edward Cree
2023-06-19 9:12 ` [PATCH 3/3] sfc: selftest: fix struct packing Arnd Bergmann
2023-06-19 10:25 ` Edward Cree
2023-06-19 13:04 ` Arnd Bergmann
2023-06-19 14:55 ` Arnd Bergmann
2023-06-23 10:52 ` David Laight
2023-06-23 12:57 ` Edward Cree [this message]
2023-06-19 10:04 ` [PATCH 1/3] [v2] sfc: add CONFIG_INET dependency for TC offload Edward Cree
2023-06-21 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f12f612-7fad-59c6-c7dd-dea49721842b@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).