From: Steve Wise <swise@opengridcomputing.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>,
dsahern@gmail.com, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
BMT@zurich.ibm.com
Subject: Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands
Date: Wed, 28 Nov 2018 16:51:43 -0600 [thread overview]
Message-ID: <0f14d192-7f3d-33f8-f778-595a8fd9c28d@opengridcomputing.com> (raw)
In-Reply-To: <20181128222558.GI19914@ziepe.ca>
On 11/28/2018 4:25 PM, Jason Gunthorpe wrote:
> On Wed, Nov 28, 2018 at 04:21:48PM -0600, Steve Wise wrote:
>
>>>> It does make sense to not require type. The name must be unique so that
>>>> should be enough. I'll have to respin the kernel side though...
>>> The delete_link really should be an operation on the ib_device, not
>>> the link_ops thing.
>>>
>>> That directly prevents mis-matching function callbacks..
>>>
>>> Jason
>> Looking at the rtnetlink newlink/dellink, I see they cache the link_ops
>> ptr in the net_device struct. So when the link is deleted, then
>> appropriate driver-specific dellink function can be called after finding
>> the device to be deleted. Should I do something along these lines? IE
>> add a struct rdma_link_ops pointer to struct ib_device.
> I don't see a problem with that either..
>
> Jason
Ok, I'll respin the kernel and user patches tomorrow. Thanks!
next prev parent reply other threads:[~2018-11-29 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:25 [PATCH RFC iproute2-next 0/2] Dynamic rdma link creation Steve Wise
2018-09-13 17:19 ` [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands Steve Wise
2018-11-28 18:26 ` Leon Romanovsky
2018-11-28 19:08 ` Steve Wise
2018-11-28 19:34 ` Steve Wise
2018-11-28 20:02 ` Leon Romanovsky
2018-11-28 20:08 ` Leon Romanovsky
2018-11-28 20:23 ` Steve Wise
2018-11-28 20:04 ` Leon Romanovsky
2018-11-28 20:07 ` Steve Wise
2018-11-28 20:13 ` Leon Romanovsky
2018-11-28 20:18 ` Steve Wise
2018-11-28 22:17 ` Jason Gunthorpe
2018-11-28 22:21 ` Steve Wise
2018-11-28 22:25 ` Jason Gunthorpe
2018-11-28 22:51 ` Steve Wise [this message]
2018-11-28 15:16 ` [PATCH RFC iproute2-next 2/2] rdma: man page update for link add/delete Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f14d192-7f3d-33f8-f778-595a8fd9c28d@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=BMT@zurich.ibm.com \
--cc=dsahern@gmail.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).