From: Andrew Lunn <andrew@lunn.ch>
To: Joel <joelcrouch@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sungem: validate BCM5411 PHY register reads
Date: Fri, 24 Apr 2026 05:45:36 +0200 [thread overview]
Message-ID: <0f243998-6cdb-46bc-8eda-11d4bbc5ae2e@lunn.ch> (raw)
In-Reply-To: <20260424033348.1917-3-joelcrouch@gmail.com>
On Fri, Apr 24, 2026 at 03:33:48AM +0000, Joel wrote:
> Check for -EIO and 0xffff during initialization to prevent silent failures. Add error logging to gem_init_phy to report failures.
I assume you have the hardware?
Looking at the git history, there have not been any fixes to this
driver since 2012. Why has this problem suddenly appeared? Is you
hardware getting flaky?
Andrew
prev parent reply other threads:[~2026-04-24 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 3:33 [PATCH v2 0/2] sungem: PHY initialization fixes and style cleanup Joel
2026-04-24 3:33 ` [PATCH v2 1/2] sungem: fix pointer formatting and indentation Joel
2026-04-24 3:33 ` [PATCH v2 2/2] sungem: validate BCM5411 PHY register reads Joel
2026-04-24 3:45 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f243998-6cdb-46bc-8eda-11d4bbc5ae2e@lunn.ch \
--to=andrew@lunn.ch \
--cc=joelcrouch@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox