From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH net-next 6/8] virtio: introduce packed ring defines Date: Wed, 4 Jul 2018 22:15:01 +0200 Message-ID: <0f293989-a0ca-e7ad-f907-83a8d8445335@redhat.com> References: <1530596284-4101-1-git-send-email-jasowang@redhat.com> <1530596284-4101-7-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: wexu@redhat.com, tiwei.bie@intel.com, jfreimann@redhat.com To: Jason Wang , mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1530596284-4101-7-git-send-email-jasowang@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/03/2018 07:38 AM, Jason Wang wrote: > diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h > index 6d5d5fa..71c7a46 100644 > --- a/include/uapi/linux/virtio_ring.h > +++ b/include/uapi/linux/virtio_ring.h > @@ -43,6 +43,8 @@ > #define VRING_DESC_F_WRITE 2 > /* This means the buffer contains a list of buffer descriptors. */ > #define VRING_DESC_F_INDIRECT 4 > +#define VRING_DESC_F_AVAIL 7 > +#define VRING_DESC_F_USED 15 For consistency, you may want to make VRING_DESC_F_AVAIL and VRING_DESC_F_USED to represent the bit mask and not the bit position, as done for VRING_DESC_F_WRITE and VRING_DESC_F_INDIRECT. Regards, Maxime