From: David Ahern <dsahern@gmail.com>
To: Jeff Barnhill <0xeffeff@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: v6/sit tunnels and VRFs
Date: Tue, 31 Oct 2017 16:36:08 -0600 [thread overview]
Message-ID: <0f2d24f1-294a-ac82-02ee-8c22d752f399@gmail.com> (raw)
In-Reply-To: <CAL6e_pfr5HRHHU9SiNKZ9dASxVLUBSHeShb_=nNd1Hbna5cR8w@mail.gmail.com>
On 10/31/17 4:20 PM, Jeff Barnhill wrote:
> Thanks, David. Those slides are extremely helpful.
>
> Also, I ran into a bug that manifested on big endian architecture:
>
> diff --git i/drivers/net/vrf.c w/drivers/net/vrf.c
> index b23bb2fae5f8..a5f984689aee 100644
> --- i/drivers/net/vrf.c
> +++ w/drivers/net/vrf.c
> @@ -1130,7 +1130,7 @@ static int vrf_fib_rule(const struct net_device
> *dev, __u8 family, bool add_it)
> frh->family = family;
> frh->action = FR_ACT_TO_TBL;
>
> - if (nla_put_u32(skb, FRA_L3MDEV, 1))
> + if (nla_put_u8(skb, FRA_L3MDEV, 1))
> goto nla_put_failure;
>
> if (nla_put_u32(skb, FRA_PRIORITY, FIB_RULE_PREF))
>
> I was surprised that nlmsg_parse in fib_nl_newrule() didn't pick this
> up, but I verified that the received value for this attribute was 0,
> not 1 (w/o the patch).
>
yikes, I am surprised the fib rule policy did not catch that.
Please submit formally with:
Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
next prev parent reply other threads:[~2017-10-31 22:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 20:45 v6/sit tunnels and VRFs Jeff Barnhill
2017-10-25 21:31 ` David Ahern
2017-10-26 3:28 ` Jeff Barnhill
2017-10-26 17:24 ` David Ahern
2017-10-27 5:19 ` Jeff Barnhill
2017-10-27 16:25 ` David Ahern
2017-10-27 20:59 ` Jeff Barnhill
2017-10-27 22:53 ` David Ahern
2017-10-28 2:43 ` Jeff Barnhill
2017-10-29 15:48 ` David Ahern
2017-10-31 22:20 ` Jeff Barnhill
2017-10-31 22:36 ` David Ahern [this message]
2017-10-31 22:42 ` David Ahern
2018-04-12 16:54 ` Jeff Barnhill
2018-04-13 2:25 ` David Ahern
2018-04-13 20:23 ` Jeff Barnhill
2018-04-13 20:31 ` David Ahern
2018-04-14 22:07 ` Jeff Barnhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f2d24f1-294a-ac82-02ee-8c22d752f399@gmail.com \
--to=dsahern@gmail.com \
--cc=0xeffeff@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).