From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] net: phylink: add debug for phy_config_inband()
Date: Wed, 18 Mar 2026 09:56:06 +0100 [thread overview]
Message-ID: <0f3a167a-3887-47ee-abf5-53f6a9a97cfb@bootlin.com> (raw)
In-Reply-To: <E1w2mFk-0000000DXW2-2PR9@rmk-PC.armlinux.org.uk>
On 18/03/2026 09:27, Russell King (Oracle) wrote:
> Add debug for the phy_config_inband() call so we can see which inband
> modes are being configured at the PHY.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Ah, useful indeed !
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Maxime
> ---
> drivers/net/phy/phylink.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 59bcc69b6c39..1c178038e6f1 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1341,6 +1341,13 @@ static void phylink_major_config(struct phylink *pl, bool restart,
> }
>
> if (pl->phydev && pl->phy_ib_mode) {
> + phylink_dbg(pl, "configuring PHY for inband%s%s%s\n",
> + pl->phy_ib_mode & LINK_INBAND_DISABLE ?
> + " disable" : "",
> + pl->phy_ib_mode & LINK_INBAND_ENABLE ?
> + " enable" : "",
> + pl->phy_ib_mode & LINK_INBAND_BYPASS ?
> + " bypass" : "");
> err = phy_config_inband(pl->phydev, pl->phy_ib_mode);
> if (err < 0) {
> phylink_err(pl, "phy_config_inband: %pe\n",
next prev parent reply other threads:[~2026-03-18 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 8:27 [PATCH net-next] net: phylink: add debug for phy_config_inband() Russell King (Oracle)
2026-03-18 8:56 ` Maxime Chevallier [this message]
2026-03-21 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3a167a-3887-47ee-abf5-53f6a9a97cfb@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox