From: Paolo Abeni <pabeni@redhat.com>
To: Ilya Maximets <i.maximets@ovn.org>, netdev@vger.kernel.org
Cc: Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>, Yuan Tan <tanyuan98@outlook.com>,
Yang Yang <n05ec@lzu.edu.cn>,
dev@openvswitch.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 2/2] selftests: openvswitch: add tests for tunnel vport refcounting
Date: Tue, 5 May 2026 15:25:05 +0200 [thread overview]
Message-ID: <0f5da49c-7ed6-4547-9f89-bb3c3d62c3c3@redhat.com> (raw)
In-Reply-To: <20260430233848.440994-3-i.maximets@ovn.org>
On 5/1/26 1:38 AM, Ilya Maximets wrote:
> @@ -830,6 +831,42 @@ test_tunnel_metadata() {
> return 0
> }
>
> +test_tunnel_refcount() {
> + sbxname="test_tunnel_refcount"
> + sbx_add "${sbxname}" || return 1
> +
> + ovs_sbx "${sbxname}" ip netns add trefns || return 1
> + on_exit "ovs_sbx ${sbxname} ip netns del trefns"
> +
> + for tun_type in gre vxlan geneve; do
> + info "testing ${tun_type} tunnel vport refcount"
> +
> + ovs_sbx "${sbxname}" ip netns exec trefns \
> + python3 $ovs_base/ovs-dpctl.py \
> + add-dp dp-${tun_type} || return 1
> +
> + ovs_sbx "${sbxname}" ip netns exec trefns \
> + python3 $ovs_base/ovs-dpctl.py \
> + add-if --no-lwt -t ${tun_type} \
> + dp-${tun_type} ovs-${tun_type}0 || return 1
> +
> + ovs_wait ip -netns trefns link show \
> + ovs-${tun_type}0 >/dev/null 2>&1 || return 1
> +
> + info "deleting dp - may hang if reference counting is broken"
> + ovs_sbx "${sbxname}" ip netns exec trefns \
> + python3 $ovs_base/ovs-dpctl.py \
> + del-dp dp-${tun_type} &
> +
> + dev_removed() {
> + ! ip -netns trefns link show "$1" >/dev/null 2>&1
> + }
> + ovs_wait dev_removed dp-${tun_type} || return 1
> + ovs_wait dev_removed ovs-${tun_type}0 || return 1
FTR, here sashiko laments that if the reference counting is broken and
the del-dp process hangs, this could leave the background del-dp python
process running indefinitely.
I guess that if reference counting is broken inside the kernel, very
likely an host/VM reboot is needed, and the above does not matter.
/P
next prev parent reply other threads:[~2026-05-05 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 23:38 [PATCH net v2 0/2] openvswitch: fix self-deadlock on release of tunnel vports Ilya Maximets
2026-04-30 23:38 ` [PATCH net v2 1/2] openvswitch: vport: fix self-deadlock on release of tunnel ports Ilya Maximets
2026-05-04 15:57 ` Aaron Conole
2026-04-30 23:38 ` [PATCH net v2 2/2] selftests: openvswitch: add tests for tunnel vport refcounting Ilya Maximets
2026-05-01 8:56 ` Eelco Chaudron
2026-05-04 15:57 ` Aaron Conole
2026-05-05 13:25 ` Paolo Abeni [this message]
2026-05-05 13:28 ` Ilya Maximets
2026-05-04 11:43 ` [PATCH net v2 0/2] openvswitch: fix self-deadlock on release of tunnel vports Ilya Maximets
2026-05-04 20:24 ` Aaron Conole
2026-05-05 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5da49c-7ed6-4547-9f89-bb3c3d62c3c3@redhat.com \
--to=pabeni@redhat.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tanyuan98@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox