From: Andrew Lunn <andrew@lunn.ch>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yixun Lan <dlan@gentoo.org>, Chukun Pan <amadeus@jmu.edu.cn>,
Michael Opdenacker <michael.opdenacker@rootcommit.com>,
netdev@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: spacemit: Clarify stat timeout comments and messages
Date: Tue, 20 Jan 2026 14:42:44 +0100 [thread overview]
Message-ID: <0f74cccd-4198-4a8a-92bb-4d4e6ae63e8d@lunn.ch> (raw)
In-Reply-To: <20260120-k1-ethernet-clarify-stat-timeout-v1-1-108cf928d1b3@iscas.ac.cn>
On Tue, Jan 20, 2026 at 12:19:23PM +0800, Vivian Wang wrote:
> Someone did run into this timeout in the wild [1], and it turns out to
> be related to the PHY reference clock stopping.
>
> Improve the comments and error message prints around this to reflect the
> better understanding of how this could happen. This patch doesn't fix
> the problem, but should direct anyone running into it in the future to
> know it is probably a PHY problem, and have a better idea what to do.
>
> Link: https://lore.kernel.org/r/20260119141620.1318102-1-amadeus@jmu.edu.cn/ # [1]
> Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
It is not clear cut, but i think this could be useful in stable. It is
not actually fixing a problem which bothers people, which is the
criteria for stable, but it is pointing people towards the solution to
a problem which will bother people. And since it is mostly comments,
it is safe.
Please add a Fixes tag for when the driver was added, and base it on
net.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-01-20 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 4:19 [PATCH net-next] net: spacemit: Clarify stat timeout comments and messages Vivian Wang
2026-01-20 13:42 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f74cccd-4198-4a8a-92bb-4d4e6ae63e8d@lunn.ch \
--to=andrew@lunn.ch \
--cc=amadeus@jmu.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.opdenacker@rootcommit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=spacemit@lists.linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox