From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <mkubecek@suse.cz>, <andrew@lunn.ch>,
<amitc@mellanox.com>, <idosch@idosch.org>, <danieller@nvidia.com>,
<jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
<jdike@addtoit.com>, <richard@nod.at>,
<anton.ivanov@cambridgegreys.com>, <netanel@amazon.com>,
<akiyano@amazon.com>, <gtzalik@amazon.com>, <saeedb@amazon.com>,
<chris.snook@gmail.com>, <ulli.kroll@googlemail.com>,
<linus.walleij@linaro.org>, <jeroendb@google.com>,
<csully@google.com>, <awogbemila@google.com>, <jdmason@kudzu.us>,
<rain.1986.08.12@gmail.com>, <zyjzyj2000@gmail.com>,
<kys@microsoft.com>, <haiyangz@microsoft.com>, <mst@redhat.com>,
<jasowang@redhat.com>, <doshir@vmware.com>,
<pv-drivers@vmware.com>, <jwi@linux.ibm.com>,
<kgraul@linux.ibm.com>, <hca@linux.ibm.com>, <gor@linux.ibm.com>,
<johannes@sipsolutions.net>, <netdev@vger.kernel.org>,
<lipeng321@huawei.com>, <chenhao288@hisilicon.com>,
<linux-s390@vger.kernel.org>
Subject: Re: [PATCH V2 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool
Date: Wed, 29 Sep 2021 10:21:11 +0800 [thread overview]
Message-ID: <0f9fcdff-8cf9-8a56-196b-afd0aee7d0c7@huawei.com> (raw)
In-Reply-To: <20210924104750.48ad3692@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2021/9/25 1:47, Jakub Kicinski wrote:
> On Fri, 24 Sep 2021 22:29:56 +0800 Guangbin Huang wrote:
>> @@ -621,9 +631,13 @@ struct ethtool_ops {
>> struct kernel_ethtool_coalesce *,
>> struct netlink_ext_ack *);
>> void (*get_ringparam)(struct net_device *,
>> - struct ethtool_ringparam *);
>> + struct ethtool_ringparam *,
>> + struct ethtool_ringparam_ext *,
>> + struct netlink_ext_ack *);
>> int (*set_ringparam)(struct net_device *,
>> - struct ethtool_ringparam *);
>> + struct ethtool_ringparam *,
>> + struct ethtool_ringparam_ext *,
>> + struct netlink_ext_ack *);
>
> You need to make the driver changes together with this chunk.
> Otherwise the build will be broken between the two during bisection.
> .
>
Ok, thanks.
next prev parent reply other threads:[~2021-09-29 2:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 14:29 [PATCH V2 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len Guangbin Huang
2021-09-24 14:29 ` [PATCH V2 net-next 1/6] ethtool: add support to set/get tx copybreak buf size via ethtool Guangbin Huang
2021-09-24 23:05 ` Michal Kubecek
2021-09-29 2:19 ` huangguangbin (A)
2021-09-24 14:29 ` [PATCH V2 net-next 2/6] net: hns3: add support to set/get tx copybreak buf size via ethtool for hns3 driver Guangbin Huang
2021-09-24 14:29 ` [PATCH V2 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool Guangbin Huang
2021-09-24 17:47 ` Jakub Kicinski
2021-09-29 2:21 ` huangguangbin (A) [this message]
2021-09-24 23:14 ` Michal Kubecek
2021-09-29 2:33 ` huangguangbin (A)
2021-09-24 14:29 ` [PATCH V2 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len Guangbin Huang
2021-09-24 14:57 ` Haiyang Zhang
2021-09-24 14:29 ` [PATCH V2 net-next 5/6] net: hns3: add support to set/get rx buf len via ethtool for hns3 driver Guangbin Huang
2021-09-24 14:29 ` [PATCH V2 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f9fcdff-8cf9-8a56-196b-afd0aee7d0c7@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=akiyano@amazon.com \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=awogbemila@google.com \
--cc=chenhao288@hisilicon.com \
--cc=chris.snook@gmail.com \
--cc=csully@google.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=gor@linux.ibm.com \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=idosch@idosch.org \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=jdmason@kudzu.us \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linus.walleij@linaro.org \
--cc=linux-s390@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rain.1986.08.12@gmail.com \
--cc=richard@nod.at \
--cc=saeedb@amazon.com \
--cc=ulli.kroll@googlemail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).