From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F817346A1E for ; Thu, 11 Sep 2025 18:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757614590; cv=none; b=Efsi2RjTYxZp1JxkfRqpxC5lHdMcop7YbUXpITpuUbHQUJ36Mi6fGIyE0eZHyWCA/RnYBXFGcmcBxnbSMnO37Mebusyw38QEAWRg2NrR0tDWpC56fRArGn3bAtC6/hyIb8Hd8HKQEMh5brKh5sOiF7gObN7S9xB/aJGKSJ0PhOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757614590; c=relaxed/simple; bh=4oW5g7VQcwRUp7W8nvq3W6DVtJW3UmQDZV1rM7GL7zo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W/4Fmxeb5Esfw1kZiG5kdzWIcY8C8lWMeJBCq+RHz5f3ObG3I98T7EEDnf1qtqY6T3dvkZwXObcidbgDDGjhBW+Wq7bGqCAKwb6l0+sNVL2fb7vcTeQ7fjXrhdmKFiOGIPR6YmHl4K/+bSACcyRtpZcBUdPWvfJOk9Hms/4YgtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ddqPBkQw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ddqPBkQw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDD14C4CEF5; Thu, 11 Sep 2025 18:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757614588; bh=4oW5g7VQcwRUp7W8nvq3W6DVtJW3UmQDZV1rM7GL7zo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ddqPBkQwt2ZztyRN/9AKh2B8DqvTzl5xFDfgfQIdX/VY85rEZNxIrXCWZTxkJcrVX PN1rUOiUX6ZzIlP94e3aStfvtwnogpbbOB1K0CsZKTWONaeTa6pU7c8nQa7bZMQUe7 JsSIJb+QroHiq4AJ2WWOxGHdIhnVtHCoX5E/vaLk3s437SurSFeYe+1rdAEqyVPrVw lwUPFrBKGEMWlW/2JkSSn0VYP9HoL+UjuPmp1n137uixIljw16xvpDBkQQsYLETgI4 nG7sg3THFI1oAOkt7O8trH+FFJexhJP/VAjBHFwVzwXSpqAhya369Ib0ueO5tgirHB elRJFhf2VGhhQ== Message-ID: <0fa3078a-1ebc-47a3-88a1-1b8713acba12@kernel.org> Date: Thu, 11 Sep 2025 20:16:23 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used To: Heiner Kallweit , Andrew Lunn Cc: Russell King - ARM Linux , Andrew Lunn , Paolo Abeni , Jakub Kicinski , Eric Dumazet , David Miller , "netdev@vger.kernel.org" References: <964df2db-082b-4977-b4c9-fbdcfc902f9e@gmail.com> <51e11917-e9c7-4708-a80f-f369874d2ed3@kernel.org> <815dcbff-ab08-4b92-acf4-6e28a230e1bf@lunn.ch> <233db109-6666-4696-9199-2da040974714@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <233db109-6666-4696-9199-2da040974714@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/09/2025 18:58, Heiner Kallweit wrote: > On 9/11/2025 6:44 PM, Andrew Lunn wrote: >> On Thu, Sep 11, 2025 at 06:28:03PM +0200, Heiner Kallweit wrote: >>> On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote: >>>> On 09/09/2025 21:16, Heiner Kallweit wrote: >>>>> The array-style fixed-link binding has been marked deprecated for more >>>>> than 10 yrs, but still there's a number of users. Print a warning when >>>>> usage of the deprecated binding is detected. >>>>> >>>>> Signed-off-by: Heiner Kallweit >>>>> --- >>>>> drivers/net/phy/phylink.c | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c >>>>> index c7f867b36..d3cb52717 100644 >>>>> --- a/drivers/net/phy/phylink.c >>>>> +++ b/drivers/net/phy/phylink.c >>>>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl, >>>>> return -EINVAL; >>>>> } >>>>> >>>>> + phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!", >>>>> + fwnode_get_name(fwnode)); >>>> Similar comment as for patch #1 - this seems to be going to printk, so >>>> use proper % format for fwnodes (I think there is as well such). >>>> >>> At least here no format for fwnodes is mentioned. >>> https://www.kernel.org/doc/Documentation/printk-formats.txt No, you are looking at wrong file. It is Documentation/core-api/printk-formats.rst Best regards, Krzysztof