From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552F216D9A8; Thu, 1 Aug 2024 12:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722514549; cv=none; b=eyzIIUYLK+QHFi3YJ3j2ukMoB8r/aHotSwZrPznsWxT+CYUUCqJB+fwvAKzaVksvssDFGFre1mEltfSR1eto+ezdSGKSKI1t18qXLMe+GvopWY8clbgBJwJGxeC9bKURas3lwMxXdJMIxDzM9+TUmPOcjt2wuzIMdwlXtL2TCF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722514549; c=relaxed/simple; bh=O+BxKiCKiBGfIj52DaS1mJTMubjl9In0/BtaRzJnESo=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=ZcAvPtGq+JstlJVepMlDcPo266+p79dEVxK+fEfpZ8UAj6G1qgczDOAcurLhR/7gsfaWVbb3cL/pwmlwCX980+YLB+KOUw+77r1rKVJAdv+OZP+vLpQ9R1SCoAEJa4byyNtot2970GBgOg0gbhraSlrxGioEA2MGU2n0cWNMCMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WZSbR4pNCzxW90; Thu, 1 Aug 2024 20:15:31 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id A35FF14041B; Thu, 1 Aug 2024 20:15:44 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 1 Aug 2024 20:15:43 +0800 Message-ID: <0fe6e62f-a6cf-4a9d-9ccc-004570c3c46e@huawei.com> Date: Thu, 1 Aug 2024 20:15:43 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH net-next 09/10] net: hibmcge: Add a Makefile and update Kconfig for hibmcge To: Andrew Lunn References: <20240731094245.1967834-1-shaojijie@huawei.com> <20240731094245.1967834-10-shaojijie@huawei.com> <49d41bc0-7a9e-4d2a-93c7-4e2bcb6d6987@lunn.ch> From: Jijie Shao In-Reply-To: <49d41bc0-7a9e-4d2a-93c7-4e2bcb6d6987@lunn.ch> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000007.china.huawei.com (7.193.23.189) on 2024/8/1 9:13, Andrew Lunn wrote: > On Wed, Jul 31, 2024 at 05:42:44PM +0800, Jijie Shao wrote: >> Add a Makefile and update Kconfig to build hibmcge driver. >> >> Signed-off-by: Jijie Shao >> --- >> drivers/net/ethernet/hisilicon/Kconfig | 17 ++++++++++++++++- >> drivers/net/ethernet/hisilicon/Makefile | 1 + >> drivers/net/ethernet/hisilicon/hibmcge/Makefile | 10 ++++++++++ >> 3 files changed, 27 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/Makefile >> >> diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig >> index 3312e1d93c3b..372854d15481 100644 >> --- a/drivers/net/ethernet/hisilicon/Kconfig >> +++ b/drivers/net/ethernet/hisilicon/Kconfig >> @@ -7,7 +7,7 @@ config NET_VENDOR_HISILICON >> bool "Hisilicon devices" >> default y >> depends on OF || ACPI >> - depends on ARM || ARM64 || COMPILE_TEST >> + depends on ARM || ARM64 || COMPILE_TEST || X86_64 > It is normal to have COMPILE_TEST last. ok， > > Any reason this won't work on S390, PowerPC etc? I have only compiled and tested on arm or x86. I can't ensure that compile or work ok on other platforms. > >> +if ARM || ARM64 || COMPILE_TEST >> + > You would normally express this with a depends on. Sorry, I can't understand how to convert if to depends on? Thanks， Jijie shao