From: Mike Frysinger <vapier@gentoo.org>
To: David Heidelberger <david.heidelberger@ixit.cz>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>, netdev@vger.kernel.org
Subject: Re: [PATCH [iputils] 4/5] fix handling of CFLAGS
Date: Sat, 19 Apr 2014 23:01:55 -0400 [thread overview]
Message-ID: <10018089.GvaJH1c73e@vapier> (raw)
In-Reply-To: <0e78909d2b809896ca107d86593ed353@ixit.cz>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Sat 19 Apr 2014 20:55:17 David Heidelberger wrote:
> I'd like to set CC if is unset, check this patch, if it look sane for
> you :)
> https://github.com/iputils/iputils/commit/77ab88974eb4424620e4caa1dcd4bebe02
> 0a3b4e
unfortunately that won't do anything. make provides a default CC so that code
will effectively never get used.
you could just delete the line. realistically, the default (cc) is going to
be gcc on any system where this code is built.
alternatively, you can use the pattern:
ifeq ($(origin CC),default)
CC = gcc
endif
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-20 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 14:43 [PATCH [iputils] 1/5] start gitignore files Mike Frysinger
2014-04-19 14:43 ` [PATCH [iputils] 2/5] doc: fix parallel build of html/man pages Mike Frysinger
2014-04-19 14:43 ` [PATCH [iputils] 3/5] ping6: allow disabling of openssl support Mike Frysinger
2014-04-19 14:43 ` [PATCH [iputils] 4/5] fix handling of CFLAGS Mike Frysinger
2014-04-19 18:55 ` David Heidelberger
2014-04-20 3:01 ` Mike Frysinger [this message]
2014-04-19 14:43 ` [PATCH [iputils] 5/5] tftpd: check return value of set*id calls Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10018089.GvaJH1c73e@vapier \
--to=vapier@gentoo.org \
--cc=david.heidelberger@ixit.cz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).