From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.holtmann.org (mail.holtmann.org [81.169.141.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCCA3B2D1A; Tue, 29 Sep 2026 20:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.169.141.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790714268; cv=none; b=D83u9ZmBYzkecdT9uzI1AE96TXchXWCReVulUkK0K+tkHRuRBmJZVJ7xfkVdMgwOt29CqkZOfxZBsKArlWo1IECPOnBq1faSj5uwbde31l9ebsLKT6FPRB2Orr/oTvueIEGHs+CMroYquavC89BYcS6J7c/NJyCVvNRtgdnz/rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790714268; c=relaxed/simple; bh=D76+O3ZMCQadvcJz+XOKNWC2ilHPP4lTIXNv9esP98g=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=m9eGSFMarfH95b8QZbpM9IttAocMviRjL0KTCij7GVSWX9dncsVDqEu0y7lUKtyCXHEavqDW7DpvXT9Y+D59oqi9+PgUmXPVtXXrd7Eu6dhqriieLa4yphUTdaVyFinusCR8dXESFHydNer0dZREQhHM1D67Hli0q57dfjR1Wfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org; spf=pass smtp.mailfrom=holtmann.org; arc=none smtp.client-ip=81.169.141.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=holtmann.org Received: from smtpclient.apple (p5b0a9ac0.dip0.t-ipconnect.de [91.10.154.192]) by mail.holtmann.org (Postfix) with ESMTPSA id 73FF2FF13C; Tue, 29 Sep 2026 22:37:44 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints From: Marcel Holtmann In-Reply-To: Date: Tue, 29 Sep 2026 22:37:34 +0200 Cc: Juha-Matti Tilli , Deepak Kumar Singh , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jeff Johnson , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, Bjorn Andersson , Chris Lew , Raj Kumar Bhagat , Jeff Hugo Content-Transfer-Encoding: quoted-printable Message-Id: <10091679-7567-42C2-B77E-EFD95CEDD649@holtmann.org> References: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> <20260922-qrtr-multi-ep-v3-2-c00831e88957@oss.qualcomm.com> <7aed969d-0868-4c9c-967e-7766dbba427e@oss.qualcomm.com> <13BFC5B0-77E6-48F2-B857-37686EA1DB2C@holtmann.org> <05e539f8-bb7c-4038-8a83-8ab0d1a5b917@app.fastmail.com> To: Manivannan Sadhasivam X-Mailer: Apple Mail (2.3901.100.1.1.12) Hi Mani, >>>>> +#define QRTR_NODE_HOST_BASE 0x10000u >>>>=20 >>>> Can it be exposed with include/uapi/linux/qrtr.h also. There are = user space clients like modem manager >>>> which need to calculate modified node id to distinguish same = service from multi modem over mhi. >>>> This is same as wlan use case. >>>=20 >>> did anybody actually looked at the proposal that Denis and I came up = with. It was exactly addressing this properly. >>>=20 >>> It seems you guys came up with some hot fix and want to run with it. = After month and month of silence and not bothering to review the = proposal, you are trying to push your thing? >>>=20 >>> If you don=E2=80=99t support userspace, your proposal is broken. = Plain and simple. >>=20 >> I'm still willing to submit a new version of that patchset originally = by >> Denis, if the kernel devs so decide that it's the way. For example, = the >> "radix tree of radix trees" approach could be replaced with a hash >> table. >>=20 >> There was also some criticism about a layering violation in storing = the >> endpoint id to mhi controller. However, maybe that could be reduced = by >> providing a correct abstraction around it, so that other code doesn't >> touch the mhi controller structure directly. >>=20 >> Other criticism for that patchset by Denis was its overt complexity. >> Yes, it has more lines of code changed. >>=20 >> This dual-card setup needs to be handled somehow, either by Denis's >> patchset or by Manivannan's patchset. >>=20 >=20 > I wish to go ahead with my series as it is simple and tested across = the > multi-WLAN setups. For concern around exposing the nid to userspace, = I'll > implement it in next version, thanks! actually no. Seems you have no plan on how to address the userspace = problem. It would be useful to actually review the endpoint_id concept introduced = by Denis since it has a userspace facing API. What is your plan? Are you = planning to break all existing userspace code? Regards Marcel